Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perseus final fixes #12362

Merged
merged 9 commits into from
Jul 3, 2024
Merged

Perseus final fixes #12362

merged 9 commits into from
Jul 3, 2024

Commits on Jun 27, 2024

  1. Allow core logging functions to accept multiple arguments.

    @rtibbles
    rtibbles committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b700590 View commit details
    Browse the repository at this point in the history

  2. Sanitize question state before attempting to restore it.

    @rtibbles
    rtibbles committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3f988f8 View commit details
    Browse the repository at this point in the history

  3. Ensure all listeners are setup before calling render to ensure answer… 

    … gets set.
    @rtibbles
    rtibbles committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    af14d94 View commit details
    Browse the repository at this point in the history

  4. Tweak variable naming to reduce confusion.

    @rtibbles
    rtibbles committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    06dcb16 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Dismiss the keypad between item renders to prevent unmounted componen… 

    …t errors.
    @rtibbles
    rtibbles committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    62c7440 View commit details
    Browse the repository at this point in the history

  2. Don't show keypad if the renderer is not interactive.

    @rtibbles
    rtibbles committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    cfb38eb View commit details
    Browse the repository at this point in the history

  3. Simplify keypad positioning to be relative to parent.

    @rtibbles
    rtibbles committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7483d1e View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Portal the keypad and have it positioned fixed, so that it can always… 

    … overlay everything.
    @rtibbles
    rtibbles committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7a19ace View commit details
    Browse the repository at this point in the history

  2. Don't pass the keypad element when not interactive to hide keypad in … 

    …static presentation.
    @rtibbles
    rtibbles committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    faaca33 View commit details
    Browse the repository at this point in the history