EQM Lesson regression fixes #12354
EQM Lesson regression fixes #12354
Conversation
github-actions
bot
added
DEV: backend
| store.commit('lessonSummary/SET_STATE', { | ||
| toolbarRoute: {}, | ||
| // only exist if exercises | ||
| workingResources: null, | ||
| resourceCache: cache, | ||
| }); | ||
|
|
There was a problem hiding this comment.
In case this looks mistaken I did add it on purpose to put visual space between the logical blocks a bit
| if (contentNode.assessmentmetadata) { | ||
| store.commit('lessonSummary/resources/SET_PREVIEW_STATE', { | ||
| questions: contentNode.assessmentmetadata.assessment_item_ids, | ||
| completionData: contentNode.assessmentmetadata.mastery_model, | ||
| }); | ||
| } |
There was a problem hiding this comment.
I initially considered just updating the lessonSummary/resources/SET_CURRENT_CONTENT_NODE handler to just set the state.preview value if/when these values are present since we're already sending it the contentNode but went with the path of least resistance here to avoid giving our neglected Vuex modules any false hope of being refactored in the future, for their fated doom is imminent.
Build Artifacts
|
There was a problem hiding this comment.
Code changes make sense, just needs manual QA.
Adding a regression test to the lesson API endpoint would be good too @nucleogenesis.
| @@ -127,7 +127,7 @@ def update(self, instance, validated_data): | |||
| # Update the scalar fields | |||
| instance.title = validated_data.get("title", instance.title) | |||
| instance.description = validated_data.get("description", instance.description) | |||
| instance.is_active = validated_data.get("active", instance.is_active) | |||
| instance.is_active = validated_data.get("is_active", instance.is_active) | |||
There was a problem hiding this comment.
Looking above, in the create method, validated data is just passed directly to the Lesson.objects.create method, so it does make sense that the validated data contains the attribute mapped to source.
| @@ -267,18 +267,22 @@ function _prepLessonContentPreview(store, classId, lessonId, contentId) { | |||
| getParams: { no_available_filtering: true }, | |||
| }).then( | |||
| contentNode => { | |||
| const assessmentMetadata = contentNode.assessmentmetadata; | |||
There was a problem hiding this comment.
Hrm, yes, I think this was a result of the refactor that removed the assessment state mapper, which presumably returned an empty object when it wasn't an exercise.
Summary
Fixes #12349 -- Cannot set lesson to visible (9fc128d)
is_activeinvalidated_data.get()call introduced in ac17541Fixes #12351 -- Cannot preview content in lesson creation (15d63b0)
Reviewer guidance
@pcenov - do these address the issues linked above?