Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to new quiz creation properly. #12352

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • When no practice quizzes were loaded onto the local device, the simple button for 'new quiz' was using the wrong link
  • This updates this, and makes sure we use the same base link object for both situations, so at least if we break it for one, we break it for both :)

References

Fixes #12302

Reviewer guidance

Import exercises, but no practice quizzes.
See that creating a new quiz takes you to a full URL.
See that you can select questions to add to the quiz.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 24, 2024
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jun 24, 2024
@marcellamaki
Copy link
Member

@pcenov @radinamatic

@pcenov
Copy link
Member

pcenov commented Jun 25, 2024

Hi @rtibbles, I confirm - creating a quiz is working correctly now with or without any available practice quizzes.

@marcellamaki marcellamaki merged commit 450e06a into learningequality:develop Jun 27, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EQM Bug: Cannot navigate to channel in resource selection if it's the only one?
3 participants