Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next attempt at fixing GCS upload #12069

Merged
merged 1 commit into from
May 3, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 9, 2024

Summary

  • My previous attempt to fix this was misguided - I assumed the issue was caused by the way the download artifact action was handling artifacts, but that was not the case.
  • Separate out BCK and other artifact upload.
  • Upload artifacts to LE downloads for all releases including prereleases, so we can test this sooner, and also get ready to create redirect links for prereleases.
  • Attempt to fix artifact upload by reverting previous change and changing destination argument for the google cloud upload seems promising due to this similar report "uploading a file" example in README seems wrong google-github-actions/upload-cloud-storage#353

References

Fixes #11908

Reviewer guidance

Clearly I was wrong last time - a quick read through and then we test this on prereleases is probably best!


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Upload artifacts to LE downloads for all releases.
Attempt to fix artifact upload.
@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment SIZE: small labels Apr 9, 2024
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems to make sense to me! I'll defer to @bjester incase he's able to spot something. Thanks @rtibbles

@akolson akolson requested a review from bjester April 30, 2024 15:12
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtibbles rtibbles merged commit f3c787d into learningequality:release-v0.16.x May 3, 2024
34 checks passed
@rtibbles rtibbles deleted the release_upload branch May 3, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants