There can be more than one network location for an instance ID #11542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
instance_id
could encounter an error if there are multipleNetworkLocation
s with the same ID, which I forgot about when I wrote the original codeReferences
In logs from @marcellamaki
Reviewer guidance
I wrote a regression test for it, which failed, then fixed the issue and the test passed, as well as all others.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)