Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and use a standard utility library for handling zip files in the frontend #11539

Merged
merged 9 commits into from
Jan 2, 2024
Merged

Create and use a standard utility library for handling zip files in the frontend #11539

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
95925d8
Create generic fflate wrapper utility.
rtibbles Nov 3, 2023
2bdcd4b
Simplify zip file loading to only need a URL.
rtibbles Nov 4, 2023
00df0d2
Move blob url creation into kolibri-zip package.
rtibbles Nov 4, 2023
2efb025
Migrate file path substitution logic into kolibri-zip package.
rtibbles Nov 14, 2023
d559cc3
Extend mimetypes.
rtibbles Nov 15, 2023
de14043
Create mapper class.
rtibbles Nov 15, 2023
9bdec4b
Add href substitution to xml and html unzipping.
rtibbles Nov 16, 2023
8336bbb
Add url caching and cleanup behaviour to kolibri-zip utility.
rtibbles Nov 17, 2023
122d1e9
Update perseus renderer to use kolibri-zip functionality.
rtibbles Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/kolibri-zip/generateMimeTypeDB.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ const allowedFileExtensions = new Set([
'md',
'textile',
'vtt',
// Additional file types for Kolibri
'html',
'htm',
'xhtml',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why these are added. Not that they shouldn't be, but more in the benefit/purpose way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I note in the PR description:

The HTML and XML utilities were also created in conjunction with work on the draft PR #8070 (making the third use case for the abstraction)

I preferred to include these edits here, as it helps to triangulate the use case for the abstraction.

]);

const output = {};
Expand Down
2 changes: 1 addition & 1 deletion packages/kolibri-zip/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "A library for reading and writing zip files",
"main": "src/index.js",
"scripts": {
"mimetypes": "node ./generateH5PMimeTypeDB.js"
"mimetypes": "node ./generateMimeTypeDB.js"
},
"author": "Learning Equality",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/kolibri-zip/src/mimetypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"js":"application/javascript","json":"application/json","doc":"application/msword","pdf":"application/pdf","rtf":"text/rtf","xls":"application/vnd.ms-excel","ppt":"application/vnd.ms-powerpoint","odp":"application/vnd.oasis.opendocument.presentation","ods":"application/vnd.oasis.opendocument.spreadsheet","odt":"application/vnd.oasis.opendocument.text","pptx":"application/vnd.openxmlformats-officedocument.presentationml.presentation","xlsx":"application/vnd.openxmlformats-officedocument.spreadsheetml.sheet","docx":"application/vnd.openxmlformats-officedocument.wordprocessingml.document","swf":"application/x-shockwave-flash","xml":"text/xml","mp3":"audio/mpeg","m4a":"audio/x-m4a","ogg":"audio/ogg","wav":"audio/x-wav","otf":"font/otf","ttf":"font/ttf","woff":"font/woff","bmp":"image/x-ms-bmp","gif":"image/gif","jpeg":"image/jpeg","jpg":"image/jpeg","png":"image/png","svg":"image/svg+xml","tif":"image/tiff","tiff":"image/tiff","css":"text/css","csv":"text/csv","md":"text/markdown","txt":"text/plain","vtt":"text/vtt","mp4":"video/mp4","webm":"video/webm"}
{"js":"application/javascript","json":"application/json","doc":"application/msword","pdf":"application/pdf","rtf":"text/rtf","xls":"application/vnd.ms-excel","ppt":"application/vnd.ms-powerpoint","odp":"application/vnd.oasis.opendocument.presentation","ods":"application/vnd.oasis.opendocument.spreadsheet","odt":"application/vnd.oasis.opendocument.text","pptx":"application/vnd.openxmlformats-officedocument.presentationml.presentation","xlsx":"application/vnd.openxmlformats-officedocument.spreadsheetml.sheet","docx":"application/vnd.openxmlformats-officedocument.wordprocessingml.document","swf":"application/x-shockwave-flash","xhtml":"application/xhtml+xml","xml":"text/xml","mp3":"audio/mpeg","m4a":"audio/x-m4a","ogg":"audio/ogg","wav":"audio/x-wav","otf":"font/otf","ttf":"font/ttf","woff":"font/woff","bmp":"image/x-ms-bmp","gif":"image/gif","jpeg":"image/jpeg","jpg":"image/jpeg","png":"image/png","svg":"image/svg+xml","tif":"image/tiff","tiff":"image/tiff","css":"text/css","csv":"text/csv","html":"text/html","htm":"text/html","md":"text/markdown","txt":"text/plain","vtt":"text/vtt","mp4":"video/mp4","webm":"video/webm"}