-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Enter key works as continue button click on Setup Wizard #11537
Ensure Enter key works as continue button click on Setup Wizard #11537
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave final approval to whoever does manual QA but on the code-front everything here looks great 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look correct to me. Will defer to @radinamatic @pcenov for manual QA sign-off. Thanks @AlexVelezLl!. @AlexVelezLl could you also add yourself as a contributor if you haven't already done so. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented as specified, thank you @AlexVelezLl!
Summary
This PR makes the use of the enter key consistent in all forms steps of the setup wizard and is the same as the behavior that would occur if the user clicks on the "Continue" button, including the form validations. This works with the steps with text inputs for now, but with the steps with radio button inputs, the issue KDS#489 must be resolved first, which prevents KRadioButtons from getting focus when rendered dynamically.
Before
Compartir.pantalla.-.2023-11-17.11_54_12.mp4
After
Compartir.pantalla.-.2023-11-20.08_39_19.mp4
References
#11458
Reviewer guidance
Go to the setup wizard and check that in forms with text inputs, the enter key works as if you clicked the enter button, including the form validations.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)