Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Enter key works as continue button click on Setup Wizard #11537

Merged

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Nov 16, 2023

Summary

This PR makes the use of the enter key consistent in all forms steps of the setup wizard and is the same as the behavior that would occur if the user clicks on the "Continue" button, including the form validations. This works with the steps with text inputs for now, but with the steps with radio button inputs, the issue KDS#489 must be resolved first, which prevents KRadioButtons from getting focus when rendered dynamically.

Before

Compartir.pantalla.-.2023-11-17.11_54_12.mp4

After

Compartir.pantalla.-.2023-11-20.08_39_19.mp4

References

#11458

Reviewer guidance

Go to the setup wizard and check that in forms with text inputs, the enter key works as if you clicked the enter button, including the form validations.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) labels Nov 16, 2023
@AlexVelezLl AlexVelezLl changed the base branch from release-v0.16.x to develop November 16, 2023 20:00
@AlexVelezLl AlexVelezLl added TAG: a11y Affecting accessibility TODO: needs review Waiting for review and removed DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) labels Nov 16, 2023
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave final approval to whoever does manual QA but on the code-front everything here looks great 👍🏻

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look correct to me. Will defer to @radinamatic @pcenov for manual QA sign-off. Thanks @AlexVelezLl!. @AlexVelezLl could you also add yourself as a contributor if you haven't already done so. Thanks

@pcenov pcenov self-requested a review November 27, 2023 14:00
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented as specified, thank you @AlexVelezLl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) SIZE: small TAG: a11y Affecting accessibility TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants