Fix unwanted welcomeModal display

[ozer550]

Summary

• Fix Incorrect welcomeModal display for guest users in learn tab.
• Change session storage to local storage for welcomeDismissalKey.

Screen shots

Before:

After:

References

closes #11202

Reviewer guidance

• Import a channel.
• Sign out explore as guest.
• Go to learn tab .
• welcomeModal does not appear.

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b6.dev0_git.241.gec8716ff.pex
Windows Installer (EXE)	kolibri-0.16.0b6.dev0+git.241.gec8716ff-unsigned.exe
Debian Package	kolibri_0.16.0b6.dev0+git.241.gec8716ff-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b6.dev0+git.241.gec8716ff-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b6.dev0+git.241.gec8716ff-0.1.0-debug.apk
TAR file	kolibri-0.16.0b6.dev0+git.241.gec8716ff.tar.gz
WHL file	kolibri-0.16.0b6.dev0+git.241.gec8716ff-py2.py3-none-any.whl

[pcenov]

Hi @ozer550 and @marcellamaki - I confirm that the original issue as described in #11202 is fixed now however if I delete all browser cookies and sign in again as a super admin I'm still seeing the rogue modal while already having imported channels. So this will keep happening for admin users every time they sign in in a new browser.

[rtibbles]

@pcenov this is definitely not a regression and is how it would have been previously, I am fairly sure - we are not tracking the dismissal in anything other than browser state, so clearing the application data will also clear the fact that the modal has been dismissed.

[rtibbles]

Code changes look correct to me.

[thanksameeelian]

this is looking good to me as well!

the change from sessionStorage to localStorage makes sense & i checked all the places i'd experienced the modal popping up at inappropriate times and was unable to replicate the previous buggy behavior! (aside from the behavior @pcenov pointed out, which as @rtibbles noted is not a regression, but more a symptom of the way we're tracking users' interactions with the modal).

thanks for tackling this @ozer550!!

[pcenov]

@rtibbles I'm not claiming it's a regression, I am pointing out that we are partially fixing a preexisting issue. The problem here is that since we are not tracking the dismissal in anything other than browser state the 'Welcome to Kolibri!' modal will show on the Library page and on Device > Channels regardless of whether the user has already imported channels or not. So it works correctly only if I am using the same browser. I can file it as a separate issue if there's anything that can be done?

Library:

2023-10-24_10-01-38.mp4

Device > Channels:

[marcellamaki]

Hi @pcenov - I think filing this as a separate issue would be great! It does make sense that we might want to add some checking about whether or not there are channels imported. Thank you