Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IMS Content Package support to the HTML5 Viewer #11436

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Oct 20, 2023

Summary

  • Upgrades le-utils and adds the relevant migration for the new format preset
  • Adds the IMSCP_ZIP format preset as a renderable format preset for the HTML5 Viewer

References

Pre-emptive support for IMSCP import when learningequality/studio#4258 is merged - it properly handles and relies on the pre-existing entry option for HTML5 apps in order to render the relevant resource from within an IMS Content Package.

Reviewer guidance

This is a little difficult for now - but it will make testing the Studio side easier once that's merged - a bit chicken and egg!


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Oct 20, 2023
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Oct 20, 2023
@rtibbles
Copy link
Member Author

Test failure was a known flaky test :/

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Funny that you have to enumerate every choice even though you're just adding one 😆

@rtibbles
Copy link
Member Author

Yeah, and it's also not even a database enforced constraint, so the migration doesn't make that much sense either!

@rtibbles rtibbles merged commit bcc470c into learningequality:release-v0.16.x Oct 23, 2023
35 checks passed
@rtibbles rtibbles deleted the imscp branch October 23, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants