Pin KDS to version 2.0.0-beta1 #11431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on the Kolibri v16 release branch Release notes: https://github.com/learningequality/kolibri-design-system/releases/tag/2.0.0-beta0 This introduces no changes to Kolibri itself since it was already up-to-date. Even though there were few changes in KDS since the last pinned commit , all of them were internal - see diff learningequality/kolibri-design-system@ab03c5e...2.0.0-beta0
Build Artifacts
|
on the Kolibri v16 release branch Release notes: https://github.com/learningequality/kolibri-design-system/releases/tag/v2.0.0-beta1
|
@marcellamaki @thanksameeelian @rtibbles The PR updated to the latest KDS pre-relase 2.0.0-beta1 (which is currently a full release candidate) |
rtibbles
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upon agreement with @marcellamaki, pins KDS to version 2.0.0-beta1 on the Kolibri v16 release branch.
Changes from the previous version to 2.0.0-beta0
KDS Release Notes: https://github.com/learningequality/kolibri-design-system/releases/tag/2.0.0-beta0
This introduces no changes to Kolibri since it was already up-to-date. Even though there were few changes in KDS since the last pinned commit, all of them were internal - see diff learningequality/kolibri-design-system@ab03c5e...2.0.0-beta0
2.0.0-beta0 to 2.0.0-beta1
KDS Release Notes: https://github.com/learningequality/kolibri-design-system/releases/tag/v2.0.0-beta1
There are no breaking changes.
References
Closes #11418
Reviewer guidance
I also briefly clicked through some places in Kolibri and noticed no apparent problems. Upcoming full Kolibri QA, for which this KDS release is supposed to be used, should reveal issues if there are some.
Testing checklist
If there are any front-end changes, before/after screenshots are includedCritical user journeys are covered by Gherkin storiesCritical and brittle code paths are covered by unit testsPR process
If this is an important user-facing change, PR or related issue has a 'changelog' labelIf this includes an internal dependency change, a link to the diff is providedReviewer checklist
yarnandpip)