Update MissingResourceAlert to report sync status

[marcellamaki]

Summary

After much discussion, adds syncing status to the MissingResourceAlert UI banner

References

Fixes #11243

Fixes #11444

missing-resources.mp4

Reviewer guidance

Run two kolibris, one with full facility and one as LOD. Previously, when the "some resources are missing or unsupported" banner would display, you should now see either a waiting to sync or syncing message. The missing or unsupported message should only happen if the resources are indeed missing, and if the sync is failed or errored in some way.

Please note that since these strings were pulled in using createTranslator, they will not be translated until make i18n-download branch=release-v0.16.x is run

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b6.dev0_git.256.gb94e789a.pex
Windows Installer (EXE)	kolibri-0.16.0b6.dev0+git.256.gb94e789a-unsigned.exe
Debian Package	kolibri_0.16.0b6.dev0+git.256.gb94e789a-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b6.dev0+git.256.gb94e789a-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b6.dev0+git.256.gb94e789a-0.1.0-debug.apk
TAR file	kolibri-0.16.0b6.dev0+git.256.gb94e789a.tar.gz
WHL file	kolibri-0.16.0b6.dev0+git.256.gb94e789a-py2.py3-none-any.whl

[radinamatic]

The missing or unsupported message should only happen if the resources are indeed missing, and if the sync is failed or errored in some way.

Tested as per the reviewer guidance, but I can still see the missing or unsupported resources notification during the normal sync that was eventually completed successfully.

Technically, while the sync is happening, the resources are missing, right? Maybe this message should only appear if the sync indeed just failed or errored, not while it is currently underway.

[marcellamaki]

@radinamatic - can you clarify about seeing the message? What you experienced was seeing
"Some resources are missing or not supported" during the sync?

Maybe this message should only appear if the sync indeed just failed or errored, not while it is currently underway.

Yes that is the intention. The purpose of this update would be two things.

1. By indicating the "The device is currently syncing" when it is, the user would have an explanation for why some lessons might not have all of the resources, such as if you click into a lesson and see nothing (as you and others experienced during one of the bug bashes)
2. Then, only if the sync had failed or errored, and resources were STILL missing or incompatible, would the "Some resources are missing or not supported" be displayed.

[radinamatic]

seeing "Some resources are missing or not supported" during the sync?

Yes, as you can see in the screencast below the notification is appearing while the sync is still in progress (thumbnails are loading), and it does not fail at any point (I can open all the videos and both the LoD and coach are displaying green checkmark for syncing).

resources-unsupported.mp4

If it matters, the LoD is in Ubuntu 18.04 VM, not on Android, and browser is set for Slow 3G throttling.

[rtibbles]

From the screencast, it looks like at least one resource was still being loaded when the page first loaded, and by the time you had viewed the first resource and returned to the playlist page, it was finished?

[rtibbles]

Needs to be updated so as not to cause odd behaviour where this is used in the Coach plugin.

[radinamatic]

it looks like at least one resource was still being loaded when the page first loaded, and by the time you had viewed the first resource and returned to the playlist page, it was finished?

Github is again messing with my mind, I wrote the reply to this yesterday, and now it's gone... 🙄

Yes, judging by the thumbnails the sync (loading) was happening, and while it is in progress, the user should see the message 'device is syncing', not 'resources missing or unsupported'.

[marcellamaki]

@rtibbles @radinamatic this should be ready for re-review now

[rtibbles]

A couple more changes needed, I think.

[marcellamaki]

@radinamatic - I lied, it will be ready for you tomorrow. I'll ping you in the morning :D

[marcellamaki]

Follow up issue here: #11444

[marcellamaki]

@radinamatic this can be re-reviewed on Monday, but importantly, the issues you noticed will not be entirely resolved until the follow up issue is finished, as this requires some additional backend changes. You can let me and Richard know if you have any questions

Updates made since.

[rtibbles]

To ensure comprehensive QA, I have pushed some updates to this PR to fix the follow up issue as well. @marcellamaki this felt easier than merging this PR and then opening a follow up.

[marcellamaki]

Thanks @rtibbles!

[pcenov]

Hi @marcellamaki, @rtibbles, @radinamatic, I was able to identify a couple of minor issues:

1. Once the sync has happened the text 'Some resources are missing or not supported Learn more' remains visible until I manually refresh the page (I waited several minutes but shortened the video). To replicate it assign a lesson with several resources and wait for the sync to happen on the LOD then on the learn-only device delete several resources and wait for the sync tor restore them on the LOD.

2023-10-23_16-08-40.mp4

2. If there are missing resources from a quiz we are explaining that within the quiz and not at the Home page so we have a bit of an inconsistent behavior:

[rtibbles]

Hrm, I'm not able to replicate 2 - quizzes with missing resources are also showing an alert on the home page.

[marcellamaki]

code review and manual QA on Richard's most recent changes - I can confirm that the banner does disappear after the sync completes (if all goes well)

[pcenov]

@rtibbles I confirm that the first issue is fixed now:

2023-10-24_11-06-28.mp4

I've reported the 2nd one here as it's still happening on my end.