Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a standard zip file reading utility wrapper using fflate #9157

Closed
rtibbles opened this issue Mar 1, 2022 · 1 comment
Closed

Create a standard zip file reading utility wrapper using fflate #9157

rtibbles opened this issue Mar 1, 2022 · 1 comment
Assignees

Comments

@rtibbles
Copy link
Member

rtibbles commented Mar 1, 2022

Currently we use JSZip in the perseus viewer library to read zip files on the client side.

In the hashi package, we use the fflate library for the same purpose.

In benchmarking, fflate seems to be much more performant that JSZip. We should make a standard utility wrapper for the fflate layer, and then utilize it in both places.

Seems simplest to create another package under packages/ to contain this, so it can be imported in hashi and in the perseus viewer.

This would also then be usable by the WIP PR here: #8070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants