The 'Welcome' modal is still being shown in LODs and normal devices if there are no imported channels

[pcenov]

Observed behavior

While regression testing #11587 I noticed that the 'Welcome' modal is still being shown in LODs and normal devices if there are no imported channels.

2023-12-14_17-20-41.mp4

Expected behavior

The 'Welcome modal' should never be displayed in LODs. For normal devices it should only be displayed once to the user and not be displayed in subsequent sign-ins with the same or a different browser.

Steps to reproduce the issue

1. Install the latest Beta 9 build asset.
2. Create a full facility and sign in.
3. Observe that the 'Welcome modal' is displayed correctly at the Library page or at Device > Channels.
4. Open a new browser window and sign in. Going to the Library page or at Device > Channels results in the modal being shown.
5. If you install the Android app and sign in as a LOD user the modal will also be displayed when there are no imported channels.

Usage Details

Beta 9
Ubuntu 22 - Chrome

[pcenov]

@radinamatic

[ThEditor]

I looked into it a bit and it seems like welcomeDismissalKey is stored in session storage of the browser and hence, when using a new browser (or clearing site data) the welcome modal comes up again. This might just be expected behaviour? I'm not sure.

Though if the welcome modal needs to stay hidden across devices (or browsers), it'll require storing this key to the account instead.

[ozer550]

Hi @ThEditor, Thanks for looking into this, we have already made some progress with this issue, to refer pr-11449 , pr-11492, pr-11587. We indeed are now using the local storage!

[rtibbles]

For normal devices it should only be displayed once to the user and not be displayed in subsequent sign-ins with the same or a different browser.

Flagging that persisting this information across browsers would require a large technical investment for little pay off, so we should instead be aiming for:

For normal devices it should only be displayed once to the user and not be displayed in subsequent sign-ins with the same browser.