LOD Syncing - A 'Synced' status is displayed instead of 'Not enough storage' when there is a storage limitation on the LOD

[pcenov]

Observed behavior

When a Coach is checking the status of the connected devices and there is an imposed storage limit on the LOD then I see the 'Synced' status instead of the 'Not enough storage' status. So far I have confirmed this behavior on Ubuntu server and Ubuntu LOD, will further test it tomorrow on Android. When I further tried testing the behavior with the download limit set to 1 GB the syncing stopped completely.

Expected behavior

The correct status should be displayed in that case.

Steps to reproduce the issue

1. Install the [Beta 7 build] from this PR (Avoid stalling LOD syncs during immediate enqueues and discovery hooks #11489).
2. Setup a server and a LOD device connected to the server.
3. As the super admin of the LOD device go to Device > Settings and set the storage limit to 0
4. As a coach go to Coach > Plan > Lessons, create a new lesson and make it visible
5. Observe that on the LOD device the status gets changed to 'Not enough storage' while at Coach > Class home > View learners it's displayed as 'Synced'

Screenshot

Logs

https://drive.google.com/drive/folders/1jRD_nHghaxbwgsloXqhqGnomb4ONJQlH?usp=drive_link

Usage Details

Ubuntu 22 - Chrome, Firefox

[pcenov]

@radinamatic

[pcenov]

In addition to the above mentioned scenario, today I imported a learner on an Android device, and then signed in as the same learner set the storage limit to 1GB and stopped the app. Then on the Ubuntu server I enabled several lessons with a total size greater than 1GB. When I started the app again it immediately tried to download the lessons, the banner for not enough storage got displayed and the sync status was 'Not enough storage' it proceeded attempting to download all resources and then at some point it just deleted all the channels and the status changed to 'Synced' as if nothing had happened.

I was able to replicate the same behavior with Ubuntu LOD.

Shorter Ubuntu LOD video:

2023-11-08_12-23-58.mp4

Android LOD video (shortened to 5 minutes instead of the original 10):

2023-11-08_11-15-09.mp4

Logs: https://drive.google.com/drive/folders/1KK-F_omgXHIuoRszFpMvuA0WWqyCQmvz?usp=drive_link