Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure "Enter" key press functions the same as a "continue" button click on all steps of the setup wizard #11458

Closed
marcellamaki opened this issue Oct 25, 2023 — with Slack · 4 comments
Assignees
Labels
DEV: frontend P1 - important Priority: High impact on UX TAG: a11y Affecting accessibility

Comments

Copy link
Member

marcellamaki commented Oct 25, 2023

There seems to be some inconsistency in the "Enter" key functionality of the setup wizard, where in some places, using the "Enter" key works to advance the form no matter what, and in other places, it requires using keyboard navigation and tabbing to the "continue" (or other primary button), and enter only works as expected when the element is in focus.

This should be solved by ensuring that when in the setup wizard, the enter key functions the same as a click on the primary button in all forms when not using keyboard navigation. It should work with keyboard navigation (using tab and seeing a focus outline appear) as well. When using keyboard navigation, the "enter" key should work as expected within the form element, and should not interfere with expected keyboard navigation options.

All form field validations should be triggered on the enter key, just as with a "click" on the relevant primary button.

(cc @radinamatic for any further A11y notes or guidance to add)

@marcellamaki marcellamaki added DEV: frontend help wanted Open source contributors welcome P1 - important Priority: High impact on UX labels Oct 25, 2023 — with Slack
@marcellamaki marcellamaki added this to the 0.16 Planned Patch 1 milestone Oct 25, 2023 — with Slack
@marcellamaki marcellamaki added the TAG: a11y Affecting accessibility label Oct 25, 2023
@Nyu10
Copy link

Nyu10 commented Nov 8, 2023

Hi, I would like to tackle this issue and expect to put up a PR in the next 2-3 weeks

@marcellamaki
Copy link
Member Author

Hi @Nyu10 - thanks for your interest! This issue has already been assigned to a member of our team. You can find additional available issues by looking for issues with no assignee with the "help wanted" tag on Kolibri or on Kolibri Studio

@Nyu10
Copy link

Nyu10 commented Nov 8, 2023

Sounds good, will look for another issue

@marcellamaki
Copy link
Member Author

Fixed in #11537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P1 - important Priority: High impact on UX TAG: a11y Affecting accessibility
Projects
None yet
Development

No branches or pull requests

5 participants