Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back link to close the immersive page is not preserved when opening the 'Next folder' link in the resource sidebar #11432

Closed
radinamatic opened this issue Oct 19, 2023 · 0 comments · Fixed by #11435
Assignees
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@radinamatic
Copy link
Member

Observed behavior

While testing the #11426 I noticed that if I use the sidebar to navigate to resources in the next folder, it's like those folders are being opened in separate immersive pages one on top of the other that afterwards need to be closed separately:

not-closing-channel.mp4

Opening the resource directly form the main panel does not produce the same issue.
@rtibbles suggests that he link generation option for preserving the back link might be set wrong.

Errors and logs

Nothing visible in the console

Expected behavior

Close (✖️) button should close the immersive page and return the user to the Library page.

User-facing consequences

Confusing navigation and inability to return to the Library page if they have been using the 'Next folder' link to navigate.

Steps to reproduce

  1. Open a resource sidebar
  2. Click the 'Next folder' link
  3. Repeat 1 and 2 several times
  4. Try closing the immersive page

Context

@radinamatic radinamatic added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Oct 19, 2023
@rtibbles rtibbles self-assigned this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants