Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default USC grade filters should only be included in comm panel #3784

Open
willgearty opened this issue Oct 30, 2024 · 0 comments
Open

Default USC grade filters should only be included in comm panel #3784

willgearty opened this issue Oct 30, 2024 · 0 comments

Comments

@willgearty
Copy link
Member

I realized today that the default min/max grade filters in the USC (added in #3424) are in effect for all uses of the USC, not just the comm panel. In doing some testing on my dev server, I tried to get schedules for all students, only to be told that their was no data to render. I realized after the fact that this was because all of the students enrolled in classes were now in grades outside the range of the program (because the program was made in 2017). While not a common edge case for most programs, I do think there are some cases where students outside of the program grade levels are allowed to enroll in a program (this is allowed via the "GradeOverride" permission). If an admin printed all schedules for such a program, these students would be excluded from the printable (and this likely wouldn't be caught until the day of the program).

Therefore, we should probably change the JS to only enable these default grade filters for commpanel instances of the USC. At the minimum, this will save some headache for web dev, and at the maximum it will save a chapter some headache due to missing schedules.

@willgearty willgearty self-assigned this Oct 30, 2024
@willgearty willgearty added this to the Stable Release 16 milestone Oct 30, 2024
willgearty added a commit that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant