Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in selecting teachers of specific student #3757

Open
milescalabresi opened this issue May 17, 2024 · 0 comments
Open

Fix bug in selecting teachers of specific student #3757

milescalabresi opened this issue May 17, 2024 · 0 comments

Comments

@milescalabresi
Copy link
Contributor

Email (or usersearch more generally) to teachers of a specific student does not work due to changes in #3445. The traceback is as follows.

esp/esp/users/controllers/usersearch.py", line 234, in query_from_criteria
    if criteria.get('target_user', '').strip():
AttributeError: 'ESPUser' object has no attribute 'strip'

Fix is to identify what the previous code (criteria['target_user']) was checking for and restore that behavior, ideally while maintaining the performance of the new criteria.get() call.

Reported by Stanford

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants