Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responsive and alignment issue on career/internship page #6009

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

upsaurav12
Copy link

Description

This PR fixes #5997
While working on this issue i have fixed the responsive issue of cards for mobile views(<450px).
Some issues were already fixed by someone else hence responsive issues on live website is not in local.

cinnamon-2024-10-19T2237210530.mp4

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: upsaurav12 . <sauravup041103@gmail.com>
Signed-off-by: upsaurav12 . <sauravup041103@gmail.com>
@upsaurav12
Copy link
Author

upsaurav12 commented Oct 19, 2024

@vishalvivekm for careers/internship it is almost fixed.
but for the route campany/brand in local env that issue is not present as it is already fixed by someone. But i see some mis-alignment issues like the label of logo is not aligned , size of images are too larger for a mobile view.

cinnamon-2024-10-19T2250260530.mp4

@l5io
Copy link
Contributor

l5io commented Oct 19, 2024

🚀 Preview for commit 18e5679 at: https://6713eb85bf1db5f032b32bf6--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 20, 2024

🚀 Preview for commit af4b8ec at: https://6714a9bbc5a1569e8c49f1ad--layer5.netlify.app

Signed-off-by: upsaurav12 . <sauravup041103@gmail.com>
Signed-off-by: upsaurav12 . <sauravup041103@gmail.com>
@l5io
Copy link
Contributor

l5io commented Oct 20, 2024

🚀 Preview for commit c95b0a2 at: https://6714ecd2086477df19b795ea--layer5.netlify.app

@vishalvivekm
Copy link
Member

@upsaurav12
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Oct 21, 2024

🚀 Preview for commit 2b03cb9 at: https://67164cc98c4e2827597f2af9--layer5.netlify.app

@upsaurav12
Copy link
Author

image
@vishalvivekm In localhost i am getting this error in my local envirement(gitpod)

@l5io
Copy link
Contributor

l5io commented Oct 30, 2024

🚀 Preview for commit 88ca4f1 at: https://6722274400d5ef9785e830f2--layer5.netlify.app

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upsaurav12 will you please exclude these changes ?

@vishalvivekm
Copy link
Member

image @vishalvivekm In localhost i am getting this error in my local envirement(gitpod)

@upsaurav12 were you able to get past this issue ?

@upsaurav12
Copy link
Author

I still getting this issue even i tried to update branch

@vishalvivekm
Copy link
Member

I still getting this issue even i tried to update branch

please once run make clean and let's see, if this resolves it.

@upsaurav12
Copy link
Author

@vishalvivekm on make setup command i am getting these error
image
I am on my gitpod and I tried to make new workspace but i got this error while doing tsetup

@l5io
Copy link
Contributor

l5io commented Nov 3, 2024

🚀 Preview for commit 4a244a6 at: https://6727a05660b79d4998b6c24f--layer5.netlify.app

@upsaurav12
Copy link
Author

@vishalvivekm i tried to run make clean and make build
image

@vishalvivekm
Copy link
Member

@vishalvivekm on make setup command i am getting these error image I am on my gitpod and I tried to make new workspace but i got this error while doing tsetup

@upsaurav12 It’s likely that these errors are due to incompatible mdx plugin dependencies which require an upgrade. ref: #6014 #4585
The make setup command (which we use to install required dependencies) accounts for this by adding the --legacy-peer-deps flag to the npm install command:

npm install --legacy-peer-deps

@vishalvivekm
Copy link
Member

@vishalvivekm i tried to run make clean and make build image

Note

make clean expects Gatsby cli to be installed on the machine. It can be installed using npm install -g gatsby-cli

Once you install gatsby cli, let’s execute the following commands in sequence:

rm -rf node_modules/
rm -rf .cache/
make setup
make clean

@upsaurav12
Copy link
Author

@vishalvivekm thank you so much now setup is working.
but i just updated the branch 1hour ago why it is still showing the branch is behind?

@upsaurav12
Copy link
Author

@vishalvivekm, while seeing the responsive of positions it is now same as in live website.
but initially it wasnt there what the reason for this?

@l5io
Copy link
Contributor

l5io commented Nov 4, 2024

🚀 Preview for commit 3526a3b at: https://67289b412a603e42c4802087--layer5.netlify.app

@upsaurav12
Copy link
Author

@vishalvivekm i have fixed the issue in both pages careers/internships and company/brand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Responsive issues on Internship, brand pages of layer5
3 participants