Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(searchbar): changed event listener to click #386

Merged
merged 5 commits into from
Oct 28, 2024
Merged

fix(searchbar): changed event listener to click #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ca1760
fix(searchbar): changed event listener to click
void-hr Oct 8, 2024
2188ab3
Merge branch 'master' of https://github.com/layer5io/docs into fix/se…
void-hr Oct 16, 2024
f8a2dcc
fix: input focus on enter and popover instance
void-hr Oct 16, 2024
e69290a
Merge branch 'master' into fix/searchbar-click
vishalvivekm Oct 21, 2024
ccea8fa
Merge branch 'master' into fix/searchbar-click
vishalvivekm Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions assets/js/offline-search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
render($(event.target));

// Hide keyboard on mobile browser
$searchInput.blur();
// $searchInput.blur();
});

// Prevent reloading page by enter key on sidebar search.
Expand Down Expand Up @@ -62,23 +62,13 @@
// Dispose existing popover
//

{
let popover = bootstrap.Popover.getInstance($targetSearchInput[0]);
if (popover !== null) {
popover.dispose();
}
}
bootstrap.Popover.getInstance($targetSearchInput[0])?.dispose();

//
// Search
//

if (idx === null) {
return;
}

const searchQuery = $targetSearchInput.val();
if (searchQuery === '') {
if (idx === null || searchQuery === "") {
return;
}

Expand Down Expand Up @@ -182,7 +172,7 @@

//Bring focus to search bar
$(document).on('keydown', function (event) {
if (event.key === '/') {
if (event.key === '/' ) {
$searchInput.focus();
}
});
Expand Down
7 changes: 6 additions & 1 deletion layouts/partials/hotkey.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@
href="https://unpkg.com/keyboard-css@1.2.4/dist/css/main.min.css"
/>
<script>
searchKey.addEventListener("mousedown", () => {
function focusSearchBar (){
var searchBar = document.querySelector(".td-search__input");
searchBar.focus();
}

searchKey.addEventListener("click", () => {
event.preventDefault();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the hotkey as well.

focusSearchBar();
});
Expand Down
Loading