Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add tips and trick: How to animate edges in Meshery Designs #337

Merged
merged 3 commits into from
Aug 5, 2024
Merged

[Docs] Add tips and trick: How to animate edges in Meshery Designs #337

merged 3 commits into from
Aug 5, 2024

Conversation

iushdoescode
Copy link
Contributor

@iushdoescode iushdoescode commented Jul 28, 2024 •
edited
Loading

Notes for Reviewers

This PR fixes #327
Screenshot 2024-07-28 111907

Signed commits

  • Yes, I signed my commits.

@iushdoescode
hyperlinked each role from permissions page
2f8f0ee 
Signed-off-by: Ayush Ukhalkar <ayushuk98@gmail.com>
@iushdoescode
Tip added to appropriate page
890a1fd 
Signed-off-by: Ayush Ukhalkar <ayushuk98@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Jul 28, 2024 •
edited
Loading

✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit e10099f
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/66ab7812ea92d4000834a2c1
😎 Deploy Preview https://deploy-preview-337--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ashparshp
Copy link
Contributor

@iushdoescode Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@jameshorton2337
Copy link
Contributor

Thank you, @iushdoescode 👏

@Ashparshp, do you have any feedback for @iushdoescode?

Ashparshp
Ashparshp reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid unnecessary tab and space changes, as they make it difficult to review by showing many lines of code changes.

@iushdoescode
Merge branch 'master' into Tip
e10099f 
Signed-off-by: Ayush Ukhalkar <97335281+iushdoescode@users.noreply.github.com>
@Ashparshp
Copy link
Contributor

@iushdoescode Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

leecalcote
leecalcote approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @iushdoescode. 🚀

@leecalcote leecalcote merged commit e5ef777 into layer5io:master Aug 5, 2024
6 checks passed
@iushdoescode iushdoescode deleted the Tip branch August 7, 2024 05:08
@Alero-Awani Alero-Awani mentioned this pull request Oct 17, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashparshp Ashparshp Ashparshp left review comments

@leecalcote leecalcote leecalcote approved these changes

@dragon-slayer875 dragon-slayer875 Awaiting requested review from dragon-slayer875

Assignees
No one assigned
Labels
component/cloud-docs component/kanvas-docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Add tips and trick: How to animate edges in Meshery Designs
4 participants
@iushdoescode @Ashparshp @jameshorton2337 @leecalcote