Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marko integration does not work without marko/node-require #227

Open
ejulen opened this issue Sep 24, 2017 · 1 comment
Open

Marko integration does not work without marko/node-require #227

ejulen opened this issue Sep 24, 2017 · 1 comment

Comments

@ejulen
Copy link

ejulen commented Sep 24, 2017

As the title says, the Marko integration does not seem to work without using the marko/node-require require hook, which according to the Lasso readme should not be used since it is deprecated:

NOTE: The reason we use require.resolve('./template.marko') instead of require('template.marko') is that Node.js does not understand how to load .marko modules and the use of the require.extensions has been deprecated.

I have made an example repository that illustrates this issue. Something I find interesting: if you remove the lasso-* tags (that is, using plain Marko), it works (but you obviously don't get any Lasso functionality).

@maxmilton
Copy link

That text you mention says that using require.extensions is deprecated not that using marko/node-require is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants