diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8f23948773..c75887bcc7 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,28 +1,47 @@ stages: - - prepare - build_n_test variables: PROJECT_NAME: singularity-eos - ENABLE_CDASH: false + ENABLE_CDASH: true GIT_SUBMODULE_STRATEGY: normal + # use this variable if there is a xcap/deployment MR you want to use instead + # PROJECT_SPACK_ENV_VERSION: mr/62/2024-10-15 include: - .gitlab/common.yml +# Spack environments are defined in +# https://re-git.lanl.gov/xcap/deployment/-/tree/xcap-spack-env/systems +# for each system and for each XCAP project. +# +# The project configuration can be found at the top of +# .gitlab/build_and_test.sh. +# +# Each environment is uniquely identified by +# ${SYSTEM_NAME}/${PROJECT_GROUP}/${PROJECT_NAME}/${SPACK_ENV_NAME} +# +# For creating a new custom environment for testing use the special +# 'custom-spec' or 'custom-file` environments. +# +# The 'custom-spec` environment allows you specify an arbitrary Spack spec to +# be added to a system-specific empty Spack environment. Use the SPACK_ENV_SPEC +# environment variable to define the spec you want to add. -######## -# Jobs # -######## +# The 'custom-file` environment allows you to manually define an environment +# from scratch. Use the SPACK_ENV_FILE environment variable to specify the +# path to the YAML file you want to use. Note, the environment will be placed +# in ${SYSTEM_NAME}/${PROJECT_GROUP}/${PROJECT_NAME}/custom-file/spack.yaml and +# can therefore make relative includes to common configuration files. -download_prereq: - stage: prepare +prereq_offline_deps: + stage: build_n_test extends: [.ascgit_job] rules: - if: $CI_PIPELINE_SOURCE == "merge_request_event" - if: $CI_PIPELINE_SOURCE == "schedule" - if: $CI_PIPELINE_SOURCE == "web" - - if: $CI_PIPELINE_SOURCE == "push" + - if: $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH needs: [] variables: GIT_SUBMODULE_STRATEGY: none @@ -34,54 +53,68 @@ download_prereq: openmpi_gcc: extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: openmpi-gcc + SUBMIT_TO_CDASH: "${ENABLE_CDASH}" openmpi_fortran_gcc: extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: openmpi-fortran-gcc + SUBMIT_TO_CDASH: "${ENABLE_CDASH}" openmpi_cuda_gcc_ampere: extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: openmpi-cuda-gcc-ampere SCHEDULER_PARAMETERS: "-N 1 --qos=debug -p shared-gpu-ampere" + SUBMIT_TO_CDASH: "${ENABLE_CDASH}" openmpi_cuda_gcc_volta: extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: openmpi-cuda-gcc-volta SCHEDULER_PARAMETERS: "-N 1 --qos=debug -p volta-x86 -C cpu_family:haswell" + SUBMIT_TO_CDASH: "${ENABLE_CDASH}" # currently disabled due to very long compilation times #openmpi_fortran_cuda_gcc_ampere: # extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] -# needs: [download_prereq] +# needs: +# - prereq_offline_deps # variables: # SPACK_ENV_NAME: openmpi-fortran-cuda-gcc-ampere # SCHEDULER_PARAMETERS: "-N 1 --qos=debug -p shared-gpu-ampere" +# SUBMIT_TO_CDASH: "${ENABLE_CDASH}" # #openmpi_fortran_cuda_gcc_volta: # extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] -# needs: [download_prereq] +# needs: +# - prereq_offline_deps # variables: # SPACK_ENV_NAME: openmpi-fortran-cuda-gcc-volta # SCHEDULER_PARAMETERS: "-N 1 --qos=debug -p volta-x86 -C cpu_family:haswell" +# SUBMIT_TO_CDASH: "${ENABLE_CDASH}" # EXAMPLE of how to modify an existing Spack environment and/or set CMake options #openmpi_cuda_gcc_volta_noclosure: # stage: build_n_test # extends: [.ascgit_job, .darwin_job, .darwin_regular_job,] -# needs: [download_prereq] +# needs: +# - prereq_offline_deps # variables: # SPACK_ENV_NAME: openmpi-cuda-gcc-volta # SCHEDULER_PARAMETERS: "-N 1 --qos=debug -p volta-x86 -C cpu_family:haswell" # SINGULARITY_EOS_SPEC: "%gcc@=12.2.0 +mpi+cuda+kokkos+spiner+hdf5+kokkos-kernels+tests~closure~fortran build_extra=sesame,stellarcollapse cuda_arch=70" +# SUBMIT_TO_CDASH: "${ENABLE_CDASH}" # script: # - source .gitlab/build_and_test.sh --until env ${CLUSTER} ${SPACK_ENV_NAME} # - spack config add "packages:singularity-eos:require:'${SINGULARITY_EOS_SPEC}'" @@ -93,50 +126,153 @@ openmpi_cuda_gcc_volta: openmpi_fortran_kokkos_openmp_gcc: extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: openmpi-fortran-kokkos-openmp-gcc + SUBMIT_TO_CDASH: "${ENABLE_CDASH}" openmpi_fortran_kokkos_static_openmp_gcc: extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: openmpi-fortran-kokkos-static-openmp-gcc + SUBMIT_TO_CDASH: "${ENABLE_CDASH}" -#openmpi_rocm_gcc: -# extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] -# needs: [download_prereq] -# variables: -# spack_env_name: openmpi-rocm-gcc -# scheduler_parameters: "-n 1 --qos=debug -p shared-gpu-amd-mi250" -# -#openmpi_fortran_rocm_gcc: -# extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] -# needs: [download_prereq] -# variables: -# spack_env_name: openmpi-fortran-rocm-gcc -# scheduler_parameters: "-n 1 --qos=debug -p shared-gpu-amd-mi250" +openmpi_rocm_gcc: + extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] + needs: + - prereq_offline_deps + variables: + SPACK_ENV_NAME: openmpi-rocm-gcc + SCHEDULER_PARAMETERS: "-n 1 --qos=debug -p shared-gpu-amd-mi250" + SUBMIT_TO_CDASH: "${ENABLE_CDASH}" + +openmpi_fortran_rocm_gcc: + extends: [.ascgit_job, .darwin_job, .darwin_regular_job, .build_and_test] + needs: + - prereq_offline_deps + variables: + SPACK_ENV_NAME: openmpi-fortran-rocm-gcc + SCHEDULER_PARAMETERS: "-n 1 --qos=debug -p shared-gpu-amd-mi250" + SUBMIT_TO_CDASH: "${ENABLE_CDASH}" rocinante_craympich_gcc: extends: [.ascgit_job, .rocinante_job, .rocinante_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: craympich-gcc + SUBMIT_TO_CDASH: false + BUILD_WITH_CTEST: "${ENABLE_CDASH}" + SUBMIT_ON_ERROR: false # Venado nodes don't have network access, don't try to send from compute node + SUBMIT_AFTER: "${ENABLE_CDASH}" # after_script runs on a network connected system rocinante_craympich_fortran_gcc: extends: [.ascgit_job, .rocinante_job, .rocinante_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: craympich-fortran-gcc + SUBMIT_TO_CDASH: false + BUILD_WITH_CTEST: "${ENABLE_CDASH}" + SUBMIT_ON_ERROR: false # Venado nodes don't have network access, don't try to send from compute node + SUBMIT_AFTER: "${ENABLE_CDASH}" # after_script runs on a network connected system + +rzansel_spectrummpi_cuda_volta_gcc: + extends: [.ascgit_job, .rzansel_job, .rzansel_regular_job, .build_and_test] + needs: + - prereq_offline_deps + variables: + SPACK_ENV_NAME: spectrummpi-cuda-volta-gcc + SUBMIT_TO_CDASH: false # disable CDash submission, since LLNL systems can't reach them + BUILD_WITH_CTEST: "${ENABLE_CDASH}" # but do build with CTest to create the necessary files + SUBMIT_ON_ERROR: false # no network access, don't try to send from compute node + SUBMIT_AFTER: false # submit host also doesn't have access to CDash server + CREATE_SUBMIT_ARTIFACT: "${ENABLE_CDASH}" # archive results + +rzansel_spectrummpi_cuda_volta_xl: + extends: [.ascgit_job, .rzansel_job, .rzansel_regular_job, .build_and_test] + needs: + - prereq_offline_deps + variables: + SPACK_ENV_NAME: spectrummpi-cuda-volta-xl + SUBMIT_TO_CDASH: false # disable CDash submission, since LLNL systems can't reach them + BUILD_WITH_CTEST: "${ENABLE_CDASH}" # but do build with CTest to create the necessary files + SUBMIT_ON_ERROR: false # no network access, don't try to send from compute node + SUBMIT_AFTER: false # submit host also doesn't have access to CDash server + CREATE_SUBMIT_ARTIFACT: "${ENABLE_CDASH}" # archive results rzvernal_craympich_rocm_mi250_cce: - extends: [.ascgit_job, .rzadams_job, .rzvernal_regular_job, .build_and_test] - needs: [download_prereq] + extends: [.ascgit_job, .rzvernal_job, .rzvernal_regular_job, .build_and_test] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: craympich-rocm-gfx90a-cce + SUBMIT_TO_CDASH: false # disable CDash submission, since LLNL systems can't reach them + BUILD_WITH_CTEST: "${ENABLE_CDASH}" # but do build with CTest to create the necessary files + SUBMIT_ON_ERROR: false # no network access, don't try to send from compute node + SUBMIT_AFTER: false # submit host also doesn't have access to CDash server + CREATE_SUBMIT_ARTIFACT: "${ENABLE_CDASH}" # archive results rzadams_craympich_rocm_mi300_cce: extends: [.ascgit_job, .rzadams_job, .rzadams_regular_job, .build_and_test] - needs: [download_prereq] + needs: + - prereq_offline_deps variables: SPACK_ENV_NAME: craympich-rocm-gfx942-cce + SUBMIT_TO_CDASH: false # disable CDash submission, since LLNL systems can't reach them + BUILD_WITH_CTEST: "${ENABLE_CDASH}" # but do build with CTest to create the necessary files + SUBMIT_ON_ERROR: false # no network access, don't try to send from compute node + SUBMIT_AFTER: false # submit host also doesn't have access to CDash server + CREATE_SUBMIT_ARTIFACT: "${ENABLE_CDASH}" # archive results + +# collect job results from RZansel and submit them to CDash +post_rzansel_results_to_cdash: + extends: [.post_results_to_cdash] + allow_failure: true + rules: + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "merge_request_event" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "schedule" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "web" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH + when: always + needs: + - rzansel_spectrummpi_cuda_volta_gcc + - rzansel_spectrummpi_cuda_volta_xl + +# collect job results from RZvernal and submit them to CDash +post_rzvernal_results_to_cdash: + extends: [.post_results_to_cdash] + allow_failure: true + rules: + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "merge_request_event" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "schedule" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "web" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH + when: always + needs: + - rzvernal_craympich_rocm_mi250_cce + +# collect job results from RZadams and submit them to CDash +post_rzadams_results_to_cdash: + extends: [.post_results_to_cdash] + allow_failure: true + rules: + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "merge_request_event" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "schedule" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "web" + when: always + - if: $ENABLE_CDASH == "true" && $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH + when: always + needs: + - rzadams_craympich_rocm_mi300_cce diff --git a/.gitlab/common.yml b/.gitlab/common.yml index 506d281050..2da1bb14b3 100644 --- a/.gitlab/common.yml +++ b/.gitlab/common.yml @@ -10,7 +10,6 @@ default: aud: https://asc-git.lanl.gov .darwin_job: - allow_failure: true variables: CLUSTER: darwin SCHEDULER_PARAMETERS: "-N 1 --qos=debug -p general,skylake-gold,skylake-platinum --constraint=\"(cpu_family:skylake)&ib:edr\"" @@ -25,7 +24,7 @@ default: - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "schedule" - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "pipeline" - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "web" - - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "push" + - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH .darwin_regular_mr_only_job: variables: @@ -40,7 +39,6 @@ default: - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "merge_request_event" - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "pipeline" - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "web" - - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_PIPELINE_SOURCE == "push" .darwin_regular_default_branch_only_job: variables: @@ -59,7 +57,6 @@ default: - if: $ENABLED_CLUSTERS =~ /darwin/ && $CI_MERGE_REQUEST_LABELS =~ /nightly/ .rocinante_job: - allow_failure: true variables: CLUSTER: rocinante SCHEDULER_PARAMETERS: "-N 1 -A asc-ci -p ci --reservation ci --time=02:00:00" @@ -74,13 +71,12 @@ default: - if: $ENABLED_CLUSTERS =~ /rocinante/ && $CI_PIPELINE_SOURCE == "merge_request_event" - if: $ENABLED_CLUSTERS =~ /rocinante/ && $CI_PIPELINE_SOURCE == "schedule" - if: $ENABLED_CLUSTERS =~ /rocinante/ && $CI_PIPELINE_SOURCE == "web" - - if: $ENABLED_CLUSTERS =~ /rocinante/ && $CI_PIPELINE_SOURCE == "push" + - if: $ENABLED_CLUSTERS =~ /rocinante/ && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH .venado_job: - allow_failure: true variables: CLUSTER: venado - SCHEDULER_PARAMETERS: "-N 1 -p standard --time=02:00:00" + SCHEDULER_PARAMETERS: "-N 1 -A lanl_ai_g -p gpu --time=02:00:00" tags: - venado - batch @@ -100,10 +96,9 @@ default: - if: $ENABLED_CLUSTERS =~ /venado/ && $GITLAB_USER_LOGIN =~ $VENADO_USERS && $CI_PIPELINE_SOURCE == "merge_request_event" - if: $ENABLED_CLUSTERS =~ /venado/ && $GITLAB_USER_LOGIN =~ $VENADO_USERS && $CI_PIPELINE_SOURCE == "schedule" - if: $ENABLED_CLUSTERS =~ /venado/ && $GITLAB_USER_LOGIN =~ $VENADO_USERS && $CI_PIPELINE_SOURCE == "web" - - if: $ENABLED_CLUSTERS =~ /venado/ && $GITLAB_USER_LOGIN =~ $VENADO_USERS && $CI_PIPELINE_SOURCE == "push" + - if: $ENABLED_CLUSTERS =~ /venado/ && $GITLAB_USER_LOGIN =~ $VENADO_USERS && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH .rzansel_job: - allow_failure: true tags: - rzansel - batch @@ -118,10 +113,9 @@ default: - if: $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "merge_request_event" - if: $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "schedule" - if: $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "web" - - if: $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "push" + - if: $ENABLED_CLUSTERS =~ /rzansel/ && $GITLAB_USER_LOGIN =~ $RZANSEL_USERS && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH .rzvernal_job: - allow_failure: true tags: - rzvernal - batch @@ -137,10 +131,9 @@ default: - if: $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "merge_request_event" - if: $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "schedule" - if: $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "web" - - if: $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "push" + - if: $ENABLED_CLUSTERS =~ /rzvernal/ && $GITLAB_USER_LOGIN =~ $RZVERNAL_USERS && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH .rzadams_job: - allow_failure: true tags: - rzadams - batch @@ -156,7 +149,7 @@ default: - if: $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "merge_request_event" - if: $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "schedule" - if: $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "web" - - if: $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "push" + - if: $ENABLED_CLUSTERS =~ /rzadams/ && $GITLAB_USER_LOGIN =~ $RZADAMS_USERS && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH .build_and_test: stage: build_n_test diff --git a/CMakeLists.txt b/CMakeLists.txt index 566db6fed0..512060bf5f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -588,7 +588,7 @@ endif() # ----------------------------------------------------------------------------# if(SINGULARITY_BUILD_TESTS) - enable_testing() + include(CTest) add_subdirectory(test) endif() diff --git a/sesame2spiner/generate_files.cpp b/sesame2spiner/generate_files.cpp index f561fa0c06..3966a9dc90 100644 --- a/sesame2spiner/generate_files.cpp +++ b/sesame2spiner/generate_files.cpp @@ -177,7 +177,7 @@ herr_t saveAllMaterials(const std::string &savename, H5LTset_attribute_string(file, "/", "singularity_version", SINGULARITY_VERSION); // log type. 0 for true, 1 for NQT1, 2 for NQT2, -1 for single precision true int log_type = singularity::FastMath::Settings::log_type; - H5LTset_attribute_int(file, "/", SP5::LogType, &log_type, 1); + H5LTset_attribute_int(file, "/", SP5::logType, &log_type, 1); std::cout << "Processing " << matids.size() << " materials..." << std::endl; diff --git a/singularity-eos/eos/singularity_eos.f90 b/singularity-eos/eos/singularity_eos.f90 index 68d21a555c..a252601eaa 100644 --- a/singularity-eos/eos/singularity_eos.f90 +++ b/singularity-eos/eos/singularity_eos.f90 @@ -13,7 +13,7 @@ !------------------------------------------------------------------------------ module singularity_eos_types - use iso_c_binding + use, intrinsic :: iso_c_binding implicit none ! data types @@ -25,7 +25,7 @@ module singularity_eos_types end module singularity_eos_types module singularity_eos - use iso_c_binding + use, intrinsic :: iso_c_binding use singularity_eos_types implicit none diff --git a/test/test_closure_pte.cpp b/test/test_closure_pte.cpp index a9c734a3e4..8a4da2d6e9 100644 --- a/test/test_closure_pte.cpp +++ b/test/test_closure_pte.cpp @@ -40,12 +40,12 @@ using singularity::DavisProducts; using singularity::DavisReactants; using singularity::IdealGas; using singularity::MAX_NUM_LAMBDAS; +using singularity::MixParams; using singularity::PTESolverRhoT; using singularity::PTESolverRhoTRequiredScratch; using singularity::ShiftedEOS; using singularity::SpinerEOSDependsRhoT; using singularity::mix_impl::CacheAccessor; -using singularity::mix_params::pte_rel_tolerance_e; using singularity::robust::ratio; using EOS = singularity::Variant, DavisProducts, @@ -188,6 +188,8 @@ SCENARIO("Density-Temperature PTE Solver", "[PTE]") { constexpr Real Cv = 0.001072 * MJ_per_kg; // erg / g / K constexpr Real Q = 4.115 * MJ_per_kg; EOS davis_p_eos = DavisProducts(a, b, k, n, vc, pc, Cv).Modify(-Q); + // PTE parameters + auto default_PTE_params = MixParams{}; GIVEN("A difficult three-material state") { // Define the state @@ -211,7 +213,7 @@ SCENARIO("Density-Temperature PTE Solver", "[PTE]") { const Real u_scale = std::abs(u_bulk); const Real u_bulk_scale = ratio(u_bulk, u_scale); const Real residual = std::abs(u_bulk_scale - ratio(u_bulk_out, u_scale)); - CHECK(residual < pte_rel_tolerance_e); + CHECK(residual < default_PTE_params.pte_rel_tolerance_e); } // Free EOS copies on device PORTABLE_FREE(v_EOS); @@ -240,7 +242,7 @@ SCENARIO("Density-Temperature PTE Solver", "[PTE]") { // const Real u_scale = std::abs(u_bulk); // const Real u_bulk_scale = ratio(u_bulk, u_scale); // const Real residual = std::abs(u_bulk_scale - ratio(u_bulk_out, u_scale)); - // CHECK(residual < pte_rel_tolerance_e); + // CHECK(residual < default_PTE_params.pte_rel_tolerance_e); // } // Free EOS copies on device PORTABLE_FREE(v_EOS);