Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORTABILITY_STRATEGY_NONE is not set as the default #29

Open
Yurlungur opened this issue Feb 13, 2023 · 2 comments
Open

PORTABILITY_STRATEGY_NONE is not set as the default #29

Yurlungur opened this issue Feb 13, 2023 · 2 comments

Comments

@Yurlungur
Copy link
Collaborator

It should be. Until this is resolved, downstream codes must set the strategy themselves.

@mauneyc-LANL
Copy link
Collaborator

The PORTABILITY_STRATEGY_NONE falls into the #else at the end of the preprocessor if-then-else.

Now, this may be somewhat imprecise, as PORTABILITY_STRATEGY_HAMSTER or PORTABILITY_TACTICS_360NOSCOPE or whatever gibberish.

Probably the best solution here is

#if !(defined PS_KOKKOS || defined PS_CUDA)
  #define PS_NONE
#endif 

#elif defined PS_NONE
//
#else 
#error "Cannot retrieve PS, check build"
#endif

@Yurlungur
Copy link
Collaborator Author

That would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants