Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2P refactor #130

Open
brryan opened this issue Oct 17, 2022 · 0 comments
Open

C2P refactor #130

brryan opened this issue Oct 17, 2022 · 0 comments

Comments

@brryan
Copy link
Collaborator

brryan commented Oct 17, 2022

Right now we have multiple fluid C2P implementations and some maybe inelegant code:

  1. con2prim_robust has its own success/failure type. This could probably be common to all c2ps
  2. c2p initialization can require a lot of arguments. It might be nice to replace this with a struct of c2p_params that can be stashed all at once in params.

So I think either remove the classic c2p (which Im pretty sure is broken anyway) or refactor all our c2p

@brryan brryan mentioned this issue Oct 17, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant