-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
result["data"] #184
Comments
I dropped this feature in IM v0.5 because it was not obvious how we could easily generalize across packages and I didn't really see a need for it anymore. Do you have a use case in mind? |
The statistics are still being reported in GasModels (as of the v0.7 branch). If we are going to continue to report it, we should keep it up to date. It was/is a nice feature to sometimes look at when inspecting a solution, but not a core feature. In terms of generalization, what about generating a foo_count for any entry at the top level of the data dictionary for which itself is a dictionary? |
Got ya. The generalization you propose could work. Another option is to have a function that each package can overload as they prefer. Part of my motivation was that a typical workflow would look like,
If you would like to summarize the solution, you would usually have the data right next to it. So you can design some arbitrary post-processing function to generate metrics that are better than the simple one that used to be in Another option would be something like,
This is even more flexible because BTW, have you tried the Do you think either of these would be a good fit for your use case? |
the print functions look like a good substitute. The resolution of this issue will be dropping support for this feature. |
Great! |
@kaarthiksundar, can we get this into the v0.7 release? |
result["data"] should report the count of the new components, such as storage, transfers, etc. Update the results_data.md file when this is done
The text was updated successfully, but these errors were encountered: