Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error_reporting setting excludes E_DEPRECATED notices #2

Open
aadmathijssen opened this issue Dec 17, 2021 · 1 comment
Open

The error_reporting setting excludes E_DEPRECATED notices #2

aadmathijssen opened this issue Dec 17, 2021 · 1 comment
Labels

Comments

@aadmathijssen
Copy link

Hi,

I was wondering why the error_reporting setting is set to E_ALL & ~E_DEPRECATED (see line 42 of the local php.ini ) instead of E_ALL.

The development version of the php.ini of PHP itself sets the value error_reporting to E_ALL:

https://github.com/php/php-src/blob/PHP-7.4/php.ini-development#L484
https://github.com/php/php-src/blob/PHP-8.0/php.ini-development#L484
https://github.com/php/php-src/blob/PHP-8.1/php.ini-development#L484

Other development solutions for PHP that I am familiar with, Homebrew and Docksal, also adhere to this default.

I prefer to have this included, as it helps in finding potential deprecations early.

But maybe there is a valid reason to exclude E_DEPRECATED notices that I'm not aware of.

Thanks.

Aad

@reynoldsalec
Copy link
Member

Good question @aadmathijssen; it's been a LONG time since anyone thought about this. Consulting the institutional memory, it sounds like we probably set something that made sense at the time for Drupal-y people or possibly that was the old PHP default years ago, and never changed it.

We're not making too many changes like this until Lando 4.x (trying to reduce variability), but this is a really good reminder for us to base the 4.x config off the established PHP recipe and to make it even easier to configure these values.

Of course for the present, you can override that setting in your own php.ini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants