Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PANTHEON_STRIPPED logic breaks REST API with json format and spaced param values #102

Open
amaisano opened this issue Feb 8, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@amaisano
Copy link

amaisano commented Feb 8, 2022

Lando 3.6.0
Drupal 8.9
Pantheon Recipe (PHP 7.3)
Local environment: Mac OS 12.2, Docker Desktop 3.6.0

my.web.site/page?_format=json&utm_content=My+Campaign results in a 406

Drupal's log shows this request as:

my.web.site/page?_format=json%20My%20Campaign

with no other parameters present.

Versions that DO work (200 response):

  • my.web.site/page?_format=json&utm_content=Campaign (no spaces)
  • my.web.site/page?_format=json&utm_c0ntent=My+Campaign (has spaces but a different spelling of "utm_content")

This does NOT affect my remote websites (dev, test, live) all work correctly given these spaced parameter values.

This only affects my local environment AFAICT.

Setting edge: false in .lando.yml prevents this problem.

@amaisano amaisano added the bug Something isn't working label Feb 8, 2022
@reynoldsalec
Copy link
Member

I'm going to guess that this is something that Lando's Varnish service needs to handle, but I'm not well versed in Varnish or how Pantheon handles these types of parameters at the edge.

Since this can be resolved by setting edge: false it doesn't seem like an immediate priority (many people turn that off anyways locally because it can introduce other complexities), but would be nice to iron this out to have closer parity to Pantheon in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants