🐛 Fix option inheritance in create_path and add tests (#617)

fix and test create_path

lamindb_setup/dev/upath.py

@@ -412,8 +412,9 @@ def create_path(pathlike: Union[str, Path, UPath]) -> UPath:
     else:
         raise ValueError("pathlike should be of type Union[str, Path, UPath]")
 
-    # ensures there's no trailing slash for directories
-    path = UPath(path.as_posix().rstrip("/"))
+    # remove trailing slash
+    if path._parts[-1] == "":
+        path._parts = path._parts[:-1]
 
     if isinstance(path, S3Path):
         path = UPath(path, cache_regions=True)

tests/prod-only/test_upath.py

@@ -0,0 +1,18 @@
+from lamindb_setup.dev.upath import UPath, create_path
+
+
+def test_create_path():
+    upath = UPath("s3://lndb-setup-ci/xyz/", default_fill_cache=False)
+    assert "default_fill_cache" in upath._kwargs
+
+    upath = create_path(upath)
+    # test option inheritance
+    assert "default_fill_cache" in upath._kwargs
+    # test cache_regions setting for s3
+    assert "cache_regions" in upath._kwargs
+    # test removal of training slash
+    assert upath.as_posix()[-1] != "/"
+    assert (
+        UPath("s3://lndb-setup-ci/xyz").as_posix()
+        == create_path("s3://lndb-setup-ci/xyz/").as_posix()
+    )