Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove maglnet/composer-require-checker as it is now in CI #35

Draft
wants to merge 1 commit into
base: 2.11.x
Choose a base branch
from

Conversation

internalsystemerror
Copy link
Member

@internalsystemerror internalsystemerror commented Sep 11, 2022

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This PR:

Signed-off-by: Gary Lockett <gary@creativecow.uk>
@internalsystemerror internalsystemerror marked this pull request as draft September 11, 2022 15:39
@gsteel
Copy link
Member

gsteel commented Sep 12, 2022

Is it planned to get composer-require-checker installed by default in the ci-action container?

@internalsystemerror
Copy link
Member Author

@gsteel Yeah I jumped the gun on this as I remember seeing that it creates the job in the CI matrix action, and assumed that the tooling was installed in there too. Then I looked at adding it and realised we're in the same position as using composer to check semver ranges, we need PHP in the node image.

This is ready to go once that is worked out however.

@gsteel
Copy link
Member

gsteel commented Sep 12, 2022

That's great news - getting it installed on older PHP versions is a pain. So once implemented, it'll run require-checker on 8.0 as opposed to the matrix default stable?

@internalsystemerror
Copy link
Member Author

internalsystemerror commented Sep 12, 2022

Ideally, I don't think it should matter as long as it can check the composer.json file, so always using the latest version sounds ideal to me. But that is something we would need to think about when it comes to adding it.

@Ocramius Ocramius added this to the 2.11.0 milestone Sep 13, 2022
@Ocramius
Copy link
Member

Do we have a blocker PR that we can reference? I still see it running vendor/bin/composer-require-checker here

@internalsystemerror
Copy link
Member Author

No PR yet, I thought this work was already done after checking the matrix, I missed that it was calling it from vendor/..., so I've created an issue for it instead. laminas/laminas-ci-matrix-action#131

@Ocramius Ocramius removed this from the 2.11.0 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants