Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic filters disappear when typing a search #914

Open
Aschen opened this issue Mar 17, 2021 · 5 comments
Open

Basic filters disappear when typing a search #914

Aschen opened this issue Mar 17, 2021 · 5 comments
Labels

Comments

@Aschen
Copy link
Contributor

Aschen commented Mar 17, 2021

Expected Behavior

The basic filter input should not disappear when typing a query in the search bar. Only the documents list should be replaced with a spinner during data reloading.

Current Behavior

The basic filter input reload after every letter you type.

admin-console-search
(DL this file and rename it with .webm)

Possible Solution

Steps to Reproduce

Context (Environment)

Kuzzle version:
Node.js version:
Admin Console version:

@xbill82
Copy link
Contributor

xbill82 commented Apr 12, 2021

What do you mean by "basic filter"? Sorry, there is much term confusion in this section... Do you mean the quick filter?

@Aschen
Copy link
Contributor Author

Aschen commented Apr 12, 2021

Those filters
image

@xbill82
Copy link
Contributor

xbill82 commented Apr 12, 2021

ok I understand! I use to call this Quick Filter, but it is indeed a Basic Filter 😄

@berthieresteban
Copy link
Contributor

I investigate a bit and discover that the FilterManager has a saveToRouter method which is called every time we change the filter (quick or advanced).
That method call router.push with the new filters in url, that is why the whole page is reloading and not just the table.
I think we should remove the good-first-issue label because we'll need to find a solution to maintain url without reloading the page and it sound a bit tricky

@xbill82
Copy link
Contributor

xbill82 commented Jun 7, 2021

@berthieresteban I think this behavior is due to the logic inside the watcher plugged on this.$router.route, which probably does something nasty which makes the input lose the focus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants