Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 plan status "vm fail" should be "partial fail" #1277

Closed
yaacov opened this issue Jul 17, 2024 · 5 comments
Closed

🐞 plan status "vm fail" should be "partial fail" #1277

yaacov opened this issue Jul 17, 2024 · 5 comments
Assignees
@sgratch
Labels
bug Categorizes issue or PR as related to a bug.
Milestone
2.6.6

Comments

@yaacov
Copy link
Member

yaacov commented Jul 17, 2024

Issue:
when one of more vms fails, we show status "vm fail" it's more helpful to call this status "partial"
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jul 17, 2024
@yaacov yaacov added this to the 2.6.4 milestone Jul 17, 2024
@yaacov yaacov modified the milestones: 2.6.4, 2.6.5, 2.6.6 Aug 27, 2024
@sgratch
Copy link
Collaborator

sgratch commented Sep 5, 2024 •
edited
Loading

There are 2 suggestions for the replaced migration status of this state where part of the VMs already failed but the plan migration is still not marked as failed:

option 1: a hard-coded "Some VMs Failed" status - suggested by @RichardHoch
option 2: a dynamic "X VMs failed" while X=num of current failed VMs status - suggested by @tashkena
option 3: a hard-coded "Partial Failed" status. Not very clear what is partial and why.

Screenshots:

Before:
Screenshot from 2024-09-05 14-18-52

After - option 1:
Screenshot from 2024-09-05 15-48-08

After - option 2:
Screenshot from 2024-09-05 16-41-21

@yaacov WDYT?

sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Sep 5, 2024
@sgratch
Rephrase migration phase label for failed VMs under uncompleted Plan
f9dea41 
Reference: kubev2v#1277

When the plan status is not set yet as failed but at least one VM under
that plan was failed to migrated already, change the phase status from
"vm fail" to "Some VMs Failed" to be more clear.

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
@sgratch sgratch mentioned this issue Sep 5, 2024
Merged
@sgratch
Copy link
Collaborator

sgratch commented Sep 5, 2024

Current PR supports option 1

@yaacov
Copy link
Member Author

yaacov commented Sep 8, 2024

closing as duplicate of: #1285

@yaacov yaacov closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2024
@yaacov yaacov reopened this Sep 8, 2024
@yaacov
Copy link
Member Author

yaacov commented Sep 8, 2024

sorry, #1285 is not a duplicate, it adds a case when vm is canceled instead of failed, and raise the question how to show users that some vms where canceled and not completed successfully.

@yaacov
Copy link
Member Author

yaacov commented Sep 8, 2024

addressed by #1318

@yaacov yaacov closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratch sgratch

Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.6.6
Development

No branches or pull requests
2 participants
@yaacov @sgratch