Make CLI tool version configurable via Makefile (#146)

* Uses variable for version in cli `cmd` package
* Makes variable configurable at compile-time via ldflags in Makefile
* Switches GitHub workflows to using Makefile argument
* Removes unnecessary set-cli-version.sh script

.github/workflows/ci.yml

@@ -194,8 +194,6 @@ jobs:
         with:
           go-version: '1.22.7'
           cache: false
-      - name: Set CLI version number
-        run: bash ./scripts/set-cli-version.sh test
       - name: Run build script
         run: make build
 
@@ -220,8 +218,6 @@ jobs:
         with:
           go-version: '1.22.7'
           cache: false  
-      - name: Set CLI version number
-        run: bash ./scripts/set-cli-version.sh test
       - name: Run build script
         run: make build
 
@@ -246,8 +242,6 @@ jobs:
         with:
           go-version: '1.22.7'
           cache: false  
-      - name: Set CLI version number
-        run: bash ./scripts/set-cli-version.sh test
       - name: Run build script
         run: make build
 
@@ -272,8 +266,6 @@ jobs:
         with:
           go-version: '1.22.7'
           cache: false
-      - name: Set CLI version number
-        run: bash ./scripts/set-cli-version.sh test
       - name: Run build script
         run: make build
 
@@ -298,8 +290,6 @@ jobs:
         with:
           go-version: '1.22.7'
           cache: false
-      - name: Set CLI version number
-        run: bash ./scripts/set-cli-version.sh test
       - name: Run build script
         run: make build
 
@@ -324,7 +314,5 @@ jobs:
         with:
           go-version: '1.22.7'
           cache: false
-      - name: Set CLI version number
-        run: bash ./scripts/set-cli-version.sh test
       - name: Run build script
         run: make build

.github/workflows/release-cli.yml

@@ -45,10 +45,8 @@ jobs:
         with:
           go-version: '1.22.7'
           cache: false
-      - name: Set CLI version number
-        run: bash ./scripts/set-cli-version.sh ${{ steps.tagName.outputs.tag }}
       - name: Run build script
-        run: make build
+        run: make build VERSION=${{ steps.tagName.outputs.tag }}
       - name: Append os/arch to binary file name
         run: mv bin/kubetail bin/kubetail-${{ matrix.GOOS }}-${{ matrix.GOARCH }}
       - name: Calculate sha256 checksum

Makefile

@@ -26,6 +26,12 @@ else
   GOARCH := $(ARCH)
 endif
 
+# Allow version override via CLI argument (default to "dev")
+VERSION ?= dev
+
+# Define ldflags
+LDFLAGS := -ldflags="-s -w -X 'github.com/kubetail-org/kubetail/modules/cli/cmd.version=$(VERSION)'"
+
 # Default target
 all: build
 
@@ -46,20 +52,20 @@ build-dashboard-ui:
 # Build CLI binary for host platform
 build-cli: build-dashboard-ui
 	@echo "Building kubetail CLI binary..."
-	@cd $(CLI_DIR) && GOOS=$(GOOS) GOARCH=$(GOARCH) CGO_ENABLED=0 go build -ldflags="-s -w" -o ../../$(OUTPUT_DIR)/$(CLI_BINARY) ./main.go
+	@cd $(CLI_DIR) && GOOS=$(GOOS) GOARCH=$(GOARCH) CGO_ENABLED=0 go build $(LDFLAGS) -o ../../$(OUTPUT_DIR)/$(CLI_BINARY) ./main.go
 
 # Build all the CLI binaries
 build-cli-all: build-dashboard-ui
 	@echo "Building kubetail CLI binaries..."
-	@cd $(CLI_DIR) && GOOS=darwin GOARCH=amd64 CGO_ENABLED=0 go build -ldflags="-s -w" -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-darwin-amd64 ./main.go
+	@cd $(CLI_DIR) && GOOS=darwin GOARCH=amd64 CGO_ENABLED=0 go build $(LDFLAGS) -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-darwin-amd64 ./main.go
 	@echo "Built kubetail for darwin-amd64."
-	@cd $(CLI_DIR) && GOOS=darwin GOARCH=arm64 CGO_ENABLED=0 go build -ldflags="-s -w" -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-darwin-arm64 ./main.go
+	@cd $(CLI_DIR) && GOOS=darwin GOARCH=arm64 CGO_ENABLED=0 go build $(LDFLAGS) -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-darwin-arm64 ./main.go
 	@echo "Built kubetail for darwin-arm64."
-	@cd $(CLI_DIR) && GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -ldflags="-s -w" -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-linux-amd64 ./main.go
+	@cd $(CLI_DIR) && GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build $(LDFLAGS) -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-linux-amd64 ./main.go
 	@echo "Built kubetail for linux-amd64."
-	@cd $(CLI_DIR) && GOOS=linux GOARCH=arm64 CGO_ENABLED=0 go build -ldflags="-s -w" -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-linux-arm64 ./main.go
+	@cd $(CLI_DIR) && GOOS=linux GOARCH=arm64 CGO_ENABLED=0 go build $(LDFLAGS) -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-linux-arm64 ./main.go
 	@echo "Built kubetail for linux-arm64."
-	@cd $(CLI_DIR) && GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go build -ldflags="-s -w" -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-windows-adm64 ./main.go
+	@cd $(CLI_DIR) && GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go build $(LDFLAGS) -o ../../$(OUTPUT_DIR)/$(CLI_BINARY)-windows-adm64 ./main.go
 	@echo "Built kubetail for windows-amd64."
 	@echo "Kubetail CLI binaries built successfully."
 

modules/cli/cmd/root.go

@@ -20,10 +20,12 @@ import (
 	"github.com/spf13/cobra"
 )
 
+var version = "dev" // default version for local builds
+
 // rootCmd represents the base command when called without any subcommands
 var rootCmd = &cobra.Command{
 	Use:     "kubetail",
-	Version: "dev",
+	Version: version,
 	Short:   "Kubetail - Kubernetes logging utility",
 }