Make TLS certificate management work for multiple OSs #48745
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Utkarsh Singh <96516301+utkarsh-singh1@users.noreply.github.com>
Co-authored-by: Utkarsh Singh <96516301+utkarsh-singh1@users.noreply.github.com>
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
/retitle Make TLS certificate management work for multiple OSs |
k8s-ci-robot
changed the title
sftim
reviewed
Nov 18, 2024
Comment on lines
+275
to
+277
| kubectl get csr my-svc.my-namespace -o json | \ | ||
| jq '.status.certificate = "'$(base64 ca-signed-server.pem | tr -d '\n')'"' | \ | ||
| kubectl replace --raw /apis/certificates.k8s.io/v1/certificatesigningrequests/my-svc.my-namespace/status -f - |
There was a problem hiding this comment.
bash isn't commonly available on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TLS certificate management task assumes Linux-style base64 command
added a tabs for the Linux, macOS and Windows
Issue
#48586