Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja]docs/concepts/security/security-checklist.md #47547 #48744

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

luna029
Copy link

@luna029 luna029 commented Nov 17, 2024

Description

Translated content/en/docs/concepts/security/security-checklist.md into Japanese.
The following Open Issues have been addressed #47547

Issue

#47547

Closes: #

Translated content/en/docs/concepts/security/security-checklist.md into Japanese.
Copy link

linux-foundation-easycla bot commented Nov 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 17, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @luna029!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign okabe-junya for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/localization General issues or PRs related to localization language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 17, 2024
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Copy link

netlify bot commented Nov 17, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 819bc9e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673f572d11e29c00081d9c38
😎 Deploy Preview https://deploy-preview-48744--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for your contribution to k/website

In Japanese, spaces are not included between words.
Additionally, our project has a style guide, so please ensure that your translation adheres to it, particularly regarding the use of half-width and full-width characters, as well as long vowel marks.

FYI: https://kubernetes.io/ja/docs/contribute/localization/#style-guide

Since Kubernetes documentation is read by many Japanese speakers, l10n is a complex task.
Please make sure to work in the language you are most proficient in.
(If you choose to move forward with this PR, refer to the style guide. If it is too difficult, feel free to close it.)

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2024
@luna029
Copy link
Author

luna029 commented Nov 17, 2024

@Okabe-Junya
Thank you for your confirmation.
This is our first submission. We apologize for any inaccuracies.
We have made several updates following the guidance below, including the points you mentioned.
We have referred you to other documents committed to the master branch for any unclear points.
We hope you will check them when you have a chance. Thank you in advance.

参考: https://kubernetes.io/ja/docs/contribute/localization/#style-guide

@Okabe-Junya
Copy link
Member

@t-inu

こちらレビューいただくことはできますか?
自分の方でも確認してlgtm, approveできたらと思います

@luna029 luna029 closed this Nov 20, 2024
@luna029 luna029 reopened this Nov 20, 2024
@t-inu
Copy link
Member

t-inu commented Nov 21, 2024

@luna029
I've reviewed until the "認証と認可" section.
Thereafter, please modify the followings first. Then I'll resume the review.

  • pod -> Pod
  • Remove spaces between words (except between English words)

luna029 and others added 7 commits November 22, 2024 00:43
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@luna029
Copy link
Author

luna029 commented Nov 22, 2024

@t-inu
Thank you for pointing out some things.
My understanding has improved. Please let me correct it again. I plan to address it over the weekend.
I would also like to add the following translation guidelines along with example sentences to the points I have been pointed out.
https://kubernetes.io/ja/docs/contribute/localization/#style-guide
I appreciate your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Translate docs/concepts/security/security-checklist.md into Japanese
5 participants