Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use canonical FontAwesome v6 icon names, upgrading from v3-v5 #48811

Open
chalin opened this issue Nov 22, 2024 · 2 comments · May be fixed by #48812
Open

Use canonical FontAwesome v6 icon names, upgrading from v3-v5 #48811

chalin opened this issue Nov 22, 2024 · 2 comments · May be fixed by #48812
Assignees
@chalin
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@chalin
Copy link
Contributor

chalin commented Nov 22, 2024 •
edited
Loading

Edit: Actually, all v3-v5 IDs should be updated to use the v6 icon's canonical name, such as the following for GitHub once Docsy is upgraded to 0.5.1+ (#48807):

<i class="fa-brands fa-github"></i>

Visit https://kubernetes.io/docs/concepts/windows/intro/ and you'll currently see the following page-meta links:

Screen Shot 2024-11-22 at 17 21 42

Notice that the <i class="fa fa-icon-circle fa-fw"></i> used to generate this icon doesn't render. The use of this icon was introduced via #29877, but even in that PR's preview the icon doesn't render, see: https://deploy-preview-29877--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/container-runtimes/#container-runtimes

image

FA v3 icon!

It took some digging, but I finally found it! That is 3 major versions back 😅. It was a FA v3 icon: https://fontawesome.com/v3/icon/circle

image

Replacement

The replacement seems to be https://fontawesome.com/icons/circle?f=classic&s=solid:

<i class="fa-solid fa-circle"></i>
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 22, 2024
@chalin chalin mentioned this issue Nov 22, 2024
Open
5 tasks
@chalin chalin changed the title Replace only FontAwesome v3 icon ID with updated ID Replace only FontAwesome v3 icon with updated ID Nov 22, 2024
@chalin chalin changed the title Replace only FontAwesome v3 icon with updated ID Use canonical FontAwesome v6 icon names, upgrading from v3-v5 Nov 22, 2024
@chalin chalin linked a pull request Nov 23, 2024 that will close this issue
Open
@dipesh-rawat
Copy link
Member

/kind bug
/area web-development

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes labels Nov 23, 2024
@dipesh-rawat
Copy link
Member

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalin chalin

Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Docsy 0.5.1 via NPM module chalin/kubernetes.io
3 participants
@chalin @dipesh-rawat @k8s-ci-robot