Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart || ServiceMonitor || support of attachMetadata: node #2557

Open
PowerSurj opened this issue Nov 20, 2024 · 1 comment
Open

Helm Chart || ServiceMonitor || support of attachMetadata: node #2557

PowerSurj opened this issue Nov 20, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@PowerSurj
Copy link

PowerSurj commented Nov 20, 2024

What would you like to be added: Capability to add node metadata e.g. node labels

Why is this needed: it would enable filtering of node metrics through node labels

Describe the solution you'd like
in servicemonitor.yaml include additional templating that can results with below

spec:
  attachMetadata:
    node: true

as for example see node-exporter
https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-node-exporter/templates/servicemonitor.yaml

  {{- with .Values.prometheus.monitor.attachMetadata }}
  attachMetadata:
    {{- toYaml . | nindent 4 }}
  {{- end }}

we could then add node labels to kube_node_info

@PowerSurj PowerSurj added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 20, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 20, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants