Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add role assignments for gmsa creds #7101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add role assignments for gmsa creds #7101

wants to merge 1 commit into from
+92 −19

Conversation

ritikaguptams
Copy link
Contributor

@ritikaguptams ritikaguptams commented Jul 30, 2024 •
edited
Loading

This PR wires all the azure role assignments required by gMSA jobs

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ritikaguptams
Once this PR has been reviewed and has the lgtm label, please assign ameukam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/azure Issues or PRs related to Kubernetes Azure infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Jul 30, 2024
@ritikaguptams ritikaguptams force-pushed the wire-gmsa-creds branch 2 times, most recently from 2eafdff to 9f67ce6 Compare July 30, 2024 20:24
@ritikaguptams ritikaguptams marked this pull request as ready for review July 30, 2024 20:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
@ritikaguptams
Copy link
Contributor Author

/assign @jsturtevant

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2024
This was referenced Jul 30, 2024
Merged
Closed
@ritikaguptams
Copy link
Contributor Author

/assign @marosset

@ameukam
Copy link
Member

ameukam commented Aug 1, 2024

@ritikaguptams Do you mind rebase to include #7106 ?

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 1, 2024
@ritikaguptams
add role assignments for gmsa creds
05a0706 
Signed-off-by: ritikaguptams <ritikagupta@microsoft.com>
@jsturtevant
Copy link
Contributor

/lgtm
we have tests passing after these changes https://testgrid.k8s.io/sig-windows-master-release#capz-windows-2022-master-serial-slow with kubernetes-sigs/windows-testing#459

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@jsturtevant jsturtevant

@marosset marosset

Labels
area/infra/azure Issues or PRs related to Kubernetes Azure infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ritikaguptams @k8s-ci-robot @ameukam @jsturtevant @marosset