-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security@etcd.io group #6542
Conversation
de5c844
to
f95201b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
I have a better idea, why don't we add the etcd.io domain to the kubernetes.io Workspace as an alias domain and then recreate the same mailing list? |
Sounds like a good idea, so we can continue to use Will it have any impact on https://etcd.io/? |
No, there is a separate issue to recreate the etcd.io DNS zone in a Google Cloud DNS project that the community owns similar to https://github.com/kubernetes/k8s.io/tree/main/dns. |
Thanks for the feedback. Let's see others' feedback on Could you provide detailed guide on how to do it? Or can we add a task in #6102? |
|
Thanks @ahrtr @upodroid Also CC'ing @mrbobbytables @BenTheElder for their thoughts, thanks! |
I think it's a good move, theres been a separate thread on what to do with the etcd google workspace so this would wrap everything up nicely. /cc |
Sounds good, thanks so much @mrbobbytables !! @ahrtr thanks for driving this, I am looking at the next steps in this direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP - we will update the PR after working on the suggestions provided by @upodroid Thanks!
Another thing to consider: has sig-etcd spoken with the Kubernetes SRC about this? Now that etcd is a part of the Kubernetes project, I would expect that vulnerability reporting would flow through them now (it wasn't specifically called out in the charter as something that sig-etcd would do differently). /hold |
@cblecker I don't know, probably not? Would you please kindly share the point of contact of k8s SRC please? |
Good point, maybe we should alias (#6542 (comment)) security@etcd.io to SRC? @wenjiaswe: |
As etcd is used as stand-alone, we want to make sure users of etcd don't feel restricted to using it with only k8s. If we can use security@etcd.io alias then using k8s SRC that should be good, IMHO. This will keep things simpler from any maintenance perspective and will keep SRC in aware of any etcd security issues. However, that means, we may want etcd maintainer representation in the SRC or SRC can simply forward issues to the maintainers group (I guess either should work). I can reach out to SRC if using SRC sounds good to you @ahrtr @wenjiaswe @serathius @jmhbnz cc @cblecker @BenTheElder Thanks! |
A quick check here on a current state of things, @cblecker :) |
What happened with this? Please let us know in #sig-k8s-infra at slack.k8s.io if there's anything blocked on us. |
Hey Team - @upodroid and I met a couple weeks ago to continue stepping through the migration of gcp projects. We got stuck on permissions and needed to reach out to the Linux Foundation listed org admin for the I did that on Kubernetes slack but checking back we haven't had a reply so I have just followed up with an email. |
Update: After a call today with @upodroid and Shah Ahmadzai from the Linux Foundation 2/3 etcd GCP projects have now been migrated to the Kubernetes org and I believe billing account has also now been updated. The one remaining project |
Also, we got access to the etcd.io Google Workspace and are currently working on delinking the domain from there and attaching it to the kubernetes.io Google Workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The domain has now been migrated. Please apply my suggestions to merge the PR.
f95201b
to
1d41561
Compare
Resolve all comments, thanks all for the help! |
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
1d41561
to
7bbb80f
Compare
Note the test case
Line 170 in 86d9aa9
|
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
ff046df
to
45d76d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, MadhavJivrajani, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@upodroid received the test email :) Thank you so much! |
Resolve kubernetes/community#7739