Accept wildcard in nginx.ingress.kubernetes.io/cors-allow-headers annotation

[croemmich]

What this PR does / why we need it:

The nginx.ingress.kubernetes.io/cors-allow-headers annotation does not allow a wildcard (*) value which is allowed both by nginx and the Fetch standard.

This PR allows the use of a wildcard in the same way nginx.ingress.kubernetes.io/cors-expose-headers already did.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

fixes #10501

How Has This Been Tested?

Updated existing tests to include wildcard

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: croemmich / name: Chris Roemmich (d648a25)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: croemmich
Once this PR has been reviewed and has the lgtm label, please assign puerco for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @croemmich!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @croemmich. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	d648a25
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67363873ea99fe0008ee4b7a

[sagar-vapi]

Hey guys,
Any chance we can merge this in? We have a dependency on it.

[johseffer]

Any chance we can merge this in?

[eggshell]

What's the outlook on merging this?

[strongjz]

What's the outlook on merging this?

Looks like there are failures for old versions and a merge conflict.

Can you rebase it?

[strongjz]

/priority backlog
/triage accepted
/kind feature

[eggshell]

@strongjz I did not author this. @croemmich any bandwidth to land this? 🙏

[croemmich]

I'll get a rebase up tomorrow morning, thanks for getting this moving again!

[croemmich]

@strongjz, this should be good to go now, thanks!

[strongjz]

/ok-to-test

[elizabeth-dev]

tested locally, working nicely