-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4951: Configurable tolerance for HPA #4954
base: master
Are you sure you want to change the base?
Conversation
Welcome @jm-franc! |
Hi @jm-franc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Looking forward to tackling a longstanding user request! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @jm-franc, thank you!
I left some suggestions in the comments, feel free to use them or tweak them further. I skipped the sections that are needed for Beta, since we're still a ways off (even the Alpha ones may be premature).
I think we can merge the end result as-is, and then work with the sig to get it to the implementable
state.
Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
Add a scaling scenario. Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
Specify that this feature won't increase resource usage. Co-authored-by: Patryk Prus <p@trykpr.us>
Add version history. Co-authored-by: Patryk Prus <p@trykpr.us>
Specify that this feature won't impact SLIs/SLOs. Co-authored-by: Patryk Prus <p@trykpr.us>
Thank you for all those suggestions Patryk, I've merged all of them. I'm now sending this KEP for review. |
This is close to what the code coverage will be in 1.32.
…ceRestriction Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Choice of max token lifetime was reconsidered during implementation. Documenting it accordingly. For ref: kubernetes/kubernetes#128190 (comment)
Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
Co-authored-by: Patryk Prus <p@trykpr.us>
53c6e1f
to
0f848b4
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jm-franc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @gjtempleton Assigning to Guy for review/approval. |
Add KEP-4951: Configurable tolerance for HPA
Issue link: #4951