Consider Terminating Pods in Deployments

[kannon92]

Enhancement Description

• One-line enhancement description (can be used as a release note): For Deployment controllers we want to optionally include a way for users to include terminating pods in the active pod count.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/3973-consider-terminating-pods-deployment/README.md
• Discussion Link: Jobs create replacement Pods as soon as a Pod is marked for deletion kubernetes#115844
• Primary contact (assignee): @atiratree
• Responsible SIGs: sig-apps
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.33
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3973: Consider Terminating Pods in Deployments #4357
    • KEP-3973: Update PodReplacementPolicy for Deployments #4670
    • KEP-3973: Update PodReplacementPolicy alpha to 1.32 #4903
  • Code (k/k) update PR(s):
    • add PodReplacementPolicy for Deployments kubernetes#123430
    • add PodReplacementPolicy for Deployments: terminating pods kubernetes#128546
  • Docs (k/website) update PR(s):
    • [KEP-3973]: docs for DeploymentPodReplacementPolicy website#48370
    • [WIP] [KEP-3973]: feature blog for DeploymentPodReplacementPolicy website#45268

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kannon92]

/sig apps

[atiratree]

@kannon92 can you please link a correct KEP in the description?

[dejanzele]

As discussed with @kannon92, I will be taking over this KEP.

/assign dejanzele

[atiratree]

@dejanzele I had a similar discussion with @kannon92 some time ago about this as well. And I have the KEP mostly written, just need to finish it..

[atiratree]

@kannon92 @dejanzele I have opened the new version of the KEP in #4357.

[kannon92]

/assign @atiratree

[atiratree]

/label lead-opted-in
/milestone v1.30
/stage alpha

[k8s-ci-robot]

@atiratree: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/label lead-opted-in
/milestone v1.30
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@atiratree: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in
/milestone v1.30
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

/label lead-opted-in
/milestone v1.30
/stage alpha

[meganwolf0]

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• The KEP and PRR look good in the Pull Request, this is just a reminder to make sure they're all merged before enhancements freeze

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[meganwolf0]

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is still at risk for enhancement freeze. Please make sure you get all changes merged before the enhancement freeze deadline. Thank you!

[salehsedghpour]

With all the requirements fulfilled in #4357 this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[celestehorgan]

Hello @kannon92 👋, 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[natalisucks]

Hi @atiratree and @dejanzele,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

[sreeram-venkitesh]

We've received an exception request for this KEP: https://groups.google.com/g/kubernetes-sig-release/c/SLTNXQvnOtM

[tjons]

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

[atiratree]

hi @soltysh and @kannon92, I would like to pursue this feature again this release. Here is the KEP update: #4903

[kannon92]

hi @soltysh and @kannon92, I would like to pursue this feature again this release. Here is the KEP update: #4903

I updated the description. I am not a sig-apps reviewer/approver but LGTM. Those yaml fields look great.

[soltysh]

/label lead-opted-in
/milestone v1.32

[SergeyKanzhelev]

Hey again @SergeyKanzhelev 👋, 1.31 Enhancements team here,

sorry, not sure why I was tagged here. Please let me know if anything needed here

[jenshu]

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting stage alpha for v1.32 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria.
• KEP has submitted a production readiness review request for approval and has a reviewer assigned.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[soltysh]

sorry, not sure why I was tagged here. Please let me know if anything needed here

I believe a simple mistake - sorry Sergey 😉

[mbianchidev]

Hi hi @dejanzele @atiratree 👋 from the v1.32 Communications Team!

We'd love for you to consider writing a feature blog about your enhancement.
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and it is graduating.

To opt-in, let us know by opening a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we finalize the blog schedule.

[rdalbuquerque]

Hello @atiratree 👋, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[atiratree]

Hi, I have opened PRs for docs and a blog:

• [KEP-3973]: docs for DeploymentPodReplacementPolicy website#48370
• [WIP] [KEP-3973]: feature blog for DeploymentPodReplacementPolicy website#45268

[jenshu]

Hey again @atiratree 👋, v1.32 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• add PodReplacementPolicy for Deployments kubernetes#123430

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[tjons]

Hello @atiratree 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.32 milestone.

If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

[atiratree]

Unfortunately we did not manage to finish the API review in time, so we will postpone this feature to the next release.

We also spun off part of the feature/review into an additional PR:

• add PodReplacementPolicy for Deployments: terminating pods kubernetes#128546

@kannon92 could you please update the description?

[atiratree]

Opened a new KEP update #4976 and targetting 1.33 now.