Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raywainman to addon-resizer owners #7521

Open
wants to merge 1 commit into
base: addon-resizer-release-1.8
Choose a base branch
from

Conversation

raywainman
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds me to the list of approvers in addon-resizer.

Addon-resizer is pretty stable and seldomly touched at this point but continues to need maintenance.

I was involved in all the recent work in addon-resizer (https://github.com/kubernetes/autoscaler/commits/addon-resizer-release-1.8/addon-resizer) and was added as a reviewer in September 2024 in #7242. I have a good grasp of the codebase and would like to offer my help to ensure there is no single-point of failure for this repository as currently there is only a single active approver.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raywainman
Once this PR has been reviewed and has the lgtm label, please assign jbartosik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2024
@kwiesmueller
Copy link
Member

lgtm from my side
/assign @gjtempleton @MaciekPytel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants