native support for ArgoRollout CRD to improve efficiency

[ZihanJiang96]

What type of PR is this?

/kind feature

What this PR does / why we need it:

We also use Argo Rollout heavily, recently we enabeld VPA in most of our clusters, and we observed the VPA controllers get throttled a lot due to the frequent /scale call.

We made the same improvement internally in a forked repo, want to contribute this back.

Which issue(s) this PR fixes:

Fixes ##7024

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

Hi @ZihanJiang96. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ZihanJiang96
Once this PR has been reviewed and has the lgtm label, please assign kgolab for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adrianmoisey]

/ok-to-test

[adrianmoisey]

/test pull-kubernetes-e2e-autoscaling-vpa-full

[adrianmoisey]

I think a change like this needs to be handled with a little more grace. For example, when running in a cluster without ArgoRollouts setup, the following errors are created:

I1122 11:50:55.800594       1 reflector.go:325] Listing and watching *v1alpha1.Rollout from k8s.io/autoscaler/vertical-pod-autoscaler/pkg/target/fetcher.go:99
W1122 11:50:55.804826       1 reflector.go:535] k8s.io/autoscaler/vertical-pod-autoscaler/pkg/target/fetcher.go:99: failed to list *v1alpha1.Rollout: rollouts.argoproj.io is forbidden: User "system:serviceaccount:kube-system:vpa-admission-controller" cannot list resource "rollouts" in API group "argoproj.io" at the cluster scope
E1122 11:50:55.804965       1 reflector.go:147] k8s.io/autoscaler/vertical-pod-autoscaler/pkg/target/fetcher.go:99: Failed to watch *v1alpha1.Rollout: failed to list *v1alpha1.Rollout: rollouts.argoproj.io is forbidden: User "system:serviceaccount:kube-system:vpa-admission-controller" cannot list resource "rollouts" in API group "argoproj.io" at the cluster scope

(well, I guess technically this is a permission issue).

Is there a way to add a feature like this in a more general manner? I'm a bit worried that this change sets a precedent that more CRs will need to be added, putting more strain the very few maintainers of this project

[k8s-ci-robot]

@ZihanJiang96: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-e2e-autoscaling-vpa-full	0181922	link	false	/test pull-kubernetes-e2e-autoscaling-vpa-full

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.