Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to upstream vLLM #22

Open
liu-cong opened this issue Oct 21, 2024 · 4 comments · May be fixed by #54
Open

Switch to upstream vLLM #22

liu-cong opened this issue Oct 21, 2024 · 4 comments · May be fixed by #54
Assignees

Comments

@liu-cong
Copy link
Contributor

We used a forked vLLM for POC for additional metrics not available in vLLM. With https://github.com/vllm-project/vllm/pull/9477/files, we have the required LoRA metrics in vLLM. This issue involves the following tasks:

  • Update metrics.go to read the new LORA metrics
  • Also read the maxLoRA metric (TODO: update the code link once PR is out)
  • Test the new vLLM release and update our manifests.
@liu-cong
Copy link
Contributor Author

/assign @coolkp

@k8s-ci-robot
Copy link
Contributor

@liu-cong: GitHub didn't allow me to assign the following users: coolkp.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @coolkp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coolkp
Copy link
Contributor

coolkp commented Oct 22, 2024

/assign @coolkp

@k8s-ci-robot
Copy link
Contributor

@coolkp: GitHub didn't allow me to assign the following users: bot, assign, to, me.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @coolkp bot assign to me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants