-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 feat: Add container check CI job #4381
base: master
Are you sure you want to change the base?
🌱 feat: Add container check CI job #4381
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mateusoliveira43. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/skip pull-kubebuilder-e2e-k8s-1-30-0 |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
13534c5
to
d381bba
Compare
- '**/*.md' | ||
pull_request: | ||
paths-ignore: | ||
- '**/*.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should only call it if
- testdata/project-v4/Makefile
- testdata/project-v4/Dockerfile
- OR this file changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, will make change
go-version: '~1.22' | ||
|
||
- name: Prepare project-v4 | ||
working-directory: testdata/project-v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could run a matrix here to check all 3 testdata folders (project-v4, project-v4-multigroup and project-v4-with-plugins). Needed or just one is enough?
|
||
- name: Prepare project-v4 | ||
working-directory: testdata/project-v4 | ||
run: go mod tidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task is to use docker-buildx, check the Docker images, and validate whether the image has been generated for all platforms.
However, I believe this is related to the changes proposed in this PR.
WDYT about we do that in another way?
What do you think about running the necessary commands in the PR to ensure everything is still working as expected after your changes? Additionally, you could include the results in the PR description to demonstrate that it works as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that yes
But would not be nice to have this automated?
If not, all PR that involve container related changes would require one more step, right?
Why the changes were made
Check that scaffolded container commands (
make docker-build
,make docker-push
andmake docker-buildx
) always work.The job checks that by building and pushing container images to ttl.sh registry.
The job also checks that scaffolded Dockerfile follows linting rules from hadolint.
How to test the changes made
Used
lint-sample.yml
as base for new job.