Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(helm/v1alpha1): Prometheus integration is not working well when enabled in the Chart #4378

Open
camilamacedo86 opened this issue Nov 22, 2024 · 5 comments · May be fixed by #4383
Open

(helm/v1alpha1): Prometheus integration is not working well when enabled in the Chart #4378

camilamacedo86 opened this issue Nov 22, 2024 · 5 comments · May be fixed by #4383
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@camilamacedo86
Copy link
Member

What broke? What's expected?

We need to add in our GitHub action to test the Helm Chart:
https://github.com/kubernetes-sigs/kubebuilder/pull/4377/files#diff-c93a79ad917924bb6a8d743a2c2b36706eeb045ed2e6b42b67b7928da9e7726aR108-R117

Then, we need to:

  • We need to ensure that we replace prometheus: false with true in the values.yaml for the CI
  • We need to fix the issue
Run helm install my-release ./dist/chart --create-namespace --namespace test-project-system
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: resource mapping not found for name: "test-project-controller-manager-metrics-monitor" namespace: "test-project-system" from "": no matches for kind "ServiceMonitor" in version "monitoring.coreos.com/v1"
ensure CRDs are installed first
Error: Process completed with exit code 1.

Reproducing this issue

No response

KubeBuilder (CLI) Version

master

PROJECT version

No response

Plugin versions

No response

Other versions

c/c @monteiro-renato

Extra Labels

No response

@camilamacedo86 camilamacedo86 added the kind/bug Categorizes issue or PR as related to a bug. label Nov 22, 2024
@monteiro-renato
Copy link
Contributor

Hey 👋
This is "expected" if the CRD hasn't been deployed to the cluster first.
That has been mentioned in the design doc as well.

@monteiro-renato
Copy link
Contributor

You could do a similar thing to what is being done in the e2e tests, which is to install the prometheus operator bundle beforehand.

@monteiro-renato
Copy link
Contributor

I can add the missing bits to the Github Action.
Simply installing the CRDs as a dependency should fix the problem.
There's an helm for the CRDs, no need to install the bundle.

@monteiro-renato
Copy link
Contributor

/assign

@monteiro-renato
Copy link
Contributor

Ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants