Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dualstack Support for the AWS SD provider #4821

Open
mjlshen opened this issue Oct 22, 2024 · 0 comments
Open

Dualstack Support for the AWS SD provider #4821

mjlshen opened this issue Oct 22, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mjlshen
Copy link
Contributor

mjlshen commented Oct 22, 2024

What would you like to be added:
In #520 and #1079, the AWS provider gained the ability to create both A and AAAA records for dualstack load balancers. This same functionality currently does not exist in the AWS-SD provider as any LoadBalancer endpoint will result in the creation of only an A record:

if ep.RecordType == endpoint.RecordTypeCNAME {
if p.isAWSLoadBalancer(target) {
attr[sdInstanceAttrAlias] = target
} else {
attr[sdInstanceAttrCname] = target
}

Why is this needed:
This is a parity item with the AWS provider and I noticed this while working on #4721 to add initial IPv6 support to the AWS-SD provider.

@mjlshen mjlshen added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant