Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit MHC for remediating machines #1862

Open
Amulyam24 opened this issue Jul 1, 2024 · 2 comments
Open

Revisit MHC for remediating machines #1862

Amulyam24 opened this issue Jul 1, 2024 · 2 comments
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@Amulyam24
Copy link
Contributor

/kind bug
/area provider/ibmcloud

What steps did you take and what happened:
While testing the cloud-provider template to be used in PowerVS CI, it has been noticed upon using MachineHealthCheck remediation is failing and the machines are being deleted once they are up and running. Revisit them and add it accordingly.

I0628 12:19:56.515707       1 recorder.go:104] "Machine default/amulya-capi-test-mhc-md/amulya-capi-test-md-0-b5c58-l6rcg/amulya-capi-test-md-0-b5c58-l6rcg has been marked as unhealthy" logger="events" type="Normal" object={"kind":"Machine","namespace":"default","name":"amulya-capi-test-md-0-b5c58-l6rcg","uid":"10225910-5706-47e0-ad62-1184e8d60b6b","apiVersion":"cluster.x-k8s.io/v1beta1","resourceVersion":"369728"} reason="MachineMarkedUnhealthy"
I0628 12:19:56.530647       1 machinehealthcheck_controller.go:435] "Target has failed health check, marking for remediation" controller="machinehealthcheck" controllerGroup="cluster.x-k8s.io" controllerKind="MachineHealthCheck" MachineHealthCheck="default/amulya-capi-test-mhc-md" namespace="default" name="amulya-capi-test-mhc-md" reconcileID="09ba737c-beca-4564-be32-4df509188210" Cluster="default/amulya-capi-test" target="default/amulya-capi-test-mhc-md/amulya-capi-test-md-0-b5c58-l6rcg/amulya-capi-test-md-0-b5c58-l6rcg" reason="UnhealthyNode" message="Condition Ready on node is reporting status False for more than 1m0s"

What did you expect to happen:
Machines to not be deleted even while passing the remediation check.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Jul 1, 2024
@mkumatag mkumatag added this to the Next milestone Jul 23, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants