-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(win): filter disks in adapter 0 to avoid mounting system drives #2662
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mweibel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @mweibel! |
Hi @mweibel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6f6f23d
to
53ee842
Compare
/ok-to-test |
the log doesn't tell me it's related to this change, but I may be wrong. Looking at the test history it looks like it's a bit flakey. /test pull-azuredisk-csi-driver-external-e2e-single-az |
@mweibel: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Filters disks returned from
ListDiskLocations
to avoid returning system drives.Which issue(s) this PR fixes:
Fixes #2661
Requirements:
Special notes for your reviewer:
Please note that I'm not 100% sure if this change fixes all potential issues. Possibly #2365 is related to this issue but I currently don't have an NVMe node around to be able to test.
Release note: